From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm2-f13.google.com (mail-wm2-f13.google.com [74.125.225.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 414832D662F for ; Wed, 30 Sep 2026 07:39:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790753995; cv=none; b=LlwCwTOH2UpsU9Y2E1eF6Cib8kYlEPx7c8Inb9pB+K5EmXC6ff1yTK8C9O9V4JmwtiYdcuyKC3TW+uaMP8aC14ZX/OTFJfgZNh0QIxLHeLA9scEJuOXsiVnR1CRjv2d1hA/Ce77giP1wwhPr2sPUxAyudE734IlnvAOYAPwXhEE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790753995; c=relaxed/simple; bh=eM9YEMN0376wWN1d6mMXq5KIUAZSu7n8NX9ie88Xhyw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=EPBWuixtzcgjY0Kw7+i6Ys6OoOJfoGo2P287uwRbkVfOLgWNpdAd16hyjCk1uTvcWDaD698ygrE8EVeGbGagtrf2LWLjbZZbpK5GmjytPkUDRnRKQwOljhZSiVLZNBthborfSCcnYx/JjZUezYF5FXQAFdEE594UGVvyDx91e5s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=VmNuXzLW; arc=none smtp.client-ip=74.125.225.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="VmNuXzLW" Received: by mail-wm2-f13.google.com with SMTP id 5b1f17b1804b1-49ffe817151so20848745e9.0 for ; Wed, 30 Sep 2026 00:39:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1790753988; x=1791358788; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=eM9YEMN0376wWN1d6mMXq5KIUAZSu7n8NX9ie88Xhyw=; b=VmNuXzLWHi4LHZJcw3wPJz9QbvnfiX2PxDkDBjAErpF3E6EdSjJ9zCMowbdhxtrGlp /+8kDQGPmSspeR0imKjPeAIJRhglj11ZGhXYpajRnDEddda/GXqyzMvfNzrtYZ2VCDWi TWWVQdE4r+O9Hu44iI5t02yvNomK6JeC5aMQ/Xia3EX4iohRLc3bb7o1FF04/1u+Qgy/ q1qBteGnxFYC9yvPTbk8LAW2PLdtYzvdKvBzynlViJSO3g2yaRKIeSTF14KkcRRhJRbv TLyPJUHk7ZHAi8T553Lyvk9xVZuBVnON9iL7Mouh26WawwcnH2ZAPGElJFDIpdwTr5kL JJtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790753988; x=1791358788; h=content-transfer-encoding:content-type:mime-version:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=eM9YEMN0376wWN1d6mMXq5KIUAZSu7n8NX9ie88Xhyw=; b=IbU6wCv3ruKcI2xmad06ohVO4SMbll9aoFtspH3CLicpoeREjZNrLtMyOsCGeui3QN mD8lx+DxhyTB7ok/PPyHQxpC5Pbvgj3w1GDbAdeEfQK2U7vOoiyxwXB2GSrkWxHzJ5zK dwiqVADWRykjG47gKrrfAlEtztZ7u6jwk3cnpsbjxitWLr8DbfzYzR+6sWByjWl2sfyC G9s3uVRhKIbMyO2oXgtC1xbkKk+sAYnJ0ODLakJya5NKyK59WlxxSZ8Ptq0NAIt1zrVd jagfRznnaKWBH5ppLtuiQX6ffz/kSu084XEvmsG+yCYJefwln5IOdCI/NWAmQof1fLPO jFGQ== X-Forwarded-Encrypted: i=1; AKwUvByY9eGm2HIkBQz9Fx5/xoCFONOqOfwhhTkFOBZJ52uU80cQYCXMhQfh3Or5G+bft1vQ40Js9WOxM6o=@vger.kernel.org X-Gm-Message-State: AFuF++lPCVVOewWWCZHScmm2R0QCa1Gxsqz116z4/AXDAq5LtqCKY6lO mqu6tSU9YTtokuhdD6EuW+5SR7o8M98NNCjIZ265VtSak/xbSQe5c4J+nGqwy6bSCllgXrrGb0X QTtbC X-Gm-Gg: AYBFou0Kmfn0MleLL0oG5OC1t6PPGPi9OVJcPiZjw10fdWmizE2cTi3qDv6K17LXhMe XzXbmbBma6y6wPOQ6HL/xxmzpARl1RWgFlUBUFMrq6aOGjswHwUNoBTFiLFbrskg2f+k8Q3BweC U0ChL98CnuyjfCZmAgsVY4dLd429kFrvjFTQYaOhxdO0qQW6Oz0SuTP8c6uZ4xBOg6BjddIgnIg W9/4C9slIzP2X7dTDm9oPuJSGunDFZLl9gfBoZEPOeRlTuF03QenD2aWeeY+K/j/62Ah6zjNNRn W7dGQz+N+yZmbq7a63M/3EwiQneshZS13NPMUPD862SsIou01dHq+6azDbFaFvHRudZKxYmqul6 1hnG+gvFLqV7FvL+6jZ/yU2Cjj/WEZ1eFpVSNxVqPacrKLWJd81usTFpdOe20pqD1Azt9xTcdsn cyYUTMf9OqSam2sak6O3fJh8vWvJU0nZ4PxZzon6BPBeo96d7tgHb6I2wEZNWsi4NerFC7V7HOu db26nVsnYs2cjr/iEMhdVfWDtec X-Received: by 2002:a05:600d:82e5:b0:4a0:61b:ede1 with SMTP id 5b1f17b1804b1-4a01afe1e93mr8170315e9.7.1790753988705; Wed, 30 Sep 2026 00:39:48 -0700 (PDT) Received: from localhost (82-67-6-57.subs.proxad.net. [82.67.6.57]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48b02949f3asm1432327f8f.1.2026.09.30.00.39.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Sep 2026 00:39:48 -0700 (PDT) From: Jerome Brunet To: Miquel Raynal , sashiko-bot@kernel.org Cc: sashiko-reviews@lists.linux.dev, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, conor+dt@kernel.org, robh@kernel.org Subject: Re: [PATCH v5 8/9] clk: nuvoton: ma35d1: get HXT/LXT from DT In-Reply-To: <871pab6bhn.fsf@bootlin.com> References: <20260929-perso-ma35d1-upstream-clk-v5-0-68533e935ee4@bootlin.com> <20260929-perso-ma35d1-upstream-clk-v5-8-68533e935ee4@bootlin.com> <20260929145618.187A21F000FF@smtp.kernel.org> <871pab6bhn.fsf@bootlin.com> Date: Wed, 30 Sep 2026 09:39:47 +0200 Message-ID: <1jzewz2nng.fsf@starbuckisacylon.baylibre.com> Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On mar. 29 sept. 2026 at 22:36, Miquel Raynal w= rote: > On 29/09/2026 at 14:56:17 GMT, sashiko-bot@kernel.org wrote: > >> Thank you for your contribution! Sashiko AI review found 2 potential iss= ue(s) to consider: >> - [High] clk: nuvoton: missing IS_ERR check causes permanent probe >> deferral > > Gasp. Yes that's correct. > >> - [Medium] clk: nuvoton: hardcoded parent strings cause orphaned gate >> clocks > > I don't think this one is serious, linkage is reliable because we > leverage the device tree nodes in the clk_core_get/clk_parse_spec > path. The fallback is indeed based on string matching, but heh, that's > because of backward compat, not my call. If think it is a legit warning. Here you say that your "hxt_gate" will parent to a clock named "hxt" in CCF, but you've got not guarantee that will be the name your externally provided clock.=20 Its fw_name is stable for you but you should make any assumption how another module will name its clock. You should use parent_data here with .fw_name that will match the externally provided clock and .name as a fallback if the clock is actually provided internally > > I will send a v6. > > Miqu=C3=A8l --=20 Jerome