From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 18 May 2015 07:54:21 +0200 From: Sascha Hauer To: Ricky Liang Cc: Mike Turquette , Stephen Boyd , Matthias Brugger , James Liao , Henry Chen , "open list:COMMON CLK FRAMEWORK" , open list , "moderated list:ARM/Mediatek SoC..." , "moderated list:ARM/Mediatek SoC..." Subject: Re: [PATCH v2] clk: mediatek: Initialize clk_init_data Message-ID: <20150518055421.GL6325@pengutronix.de> References: <1431920513-1491-1-git-send-email-jcliang@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1431920513-1491-1-git-send-email-jcliang@chromium.org> List-ID: Hi Ricky, On Mon, May 18, 2015 at 11:41:49AM +0800, Ricky Liang wrote: > The variable init (struct clk_init_data) is allocated on the stack. > We weren't initializing the .flags field, so it contains random junk, > which can cause all kinds of interesting issues when the flags are > parsed by clk_register. It seems we have the same problem in clk-gate.c aswell. We do initialize do .flags field there, so this is no urgent problem, but we might get a real problem when additional fields are added to struct clk_init_data. Care to fix that aswell along with this patch? Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |