From: Michael Turquette <mturquette@linaro.org>
To: Tero Kristo <t-kristo@ti.com>, "Tony Lindgren" <tony@atomide.com>
Cc: balbi@ti.com, linux-clk@vger.kernel.org,
linux-omap@vger.kernel.org, sboyd@codeaurora.org, paul@pwsan.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv3 00/27] ARM: OMAP2+: clock code move under clk driver
Date: Wed, 03 Jun 2015 16:11:36 -0700 [thread overview]
Message-ID: <20150603231136.6017.65683@quantum> (raw)
In-Reply-To: <556EF42A.9000207@ti.com>
Quoting Tero Kristo (2015-06-03 05:33:46)
> On 05/28/2015 02:15 AM, Tony Lindgren wrote:
> > * Tero Kristo <t-kristo@ti.com> [150527 11:32]:
> >> On 05/26/2015 07:39 PM, Felipe Balbi wrote:
> >>> On Tue, May 26, 2015 at 09:32:16AM -0700, Tony Lindgren wrote:
> >>>> * Tony Lindgren <tony@atomide.com> [150526 09:08]:
> >>>>> * Tero Kristo <t-kristo@ti.com> [150525 08:01]:
> >>>>>> Hi,
> >>>>>>
> >>>>>> As requested, posting v3 with somewhat changed diff parameters and
> >>>>>> diffstat attached. Just some minor Makefile changes compared to v2,
> >>>>>> these were discussed under that set.
> >>>>>>
> >>>>>> Set has been pushed to:
> >>>>>> - tree: https://github.com/t-kristo/linux-pm.git
> >>>>>> - branch: for-4.2/ti-clk-move
> >>>>>
> >>>>> Looks like this causes a build error for at least omap2 only .confi=
g:
> >>>>>
> >>>>> drivers/clk/ti/dpll3xxx.o:(.rodata+0x1c): multiple definition of `c=
lkhwops_omap3_dpll'
> >>>>> drivers/clk/ti/dpll.o:(.rodata+0x0): first defined here
> >>>>>
> >>>>> You may want to create a file selecting ARCH_OMAP2PLUS=3Dy, then po=
int
> >>>>> KCONFIG_ALLCONFIG to that file for make randconfig. Then just build
> >>>>> randconfigs :) Usually the issues like this are exposed within few
> >>>>> randconfig builds, some take longer if the options have dependencie=
s.
> >>>
> >>> alternatively, just clone the repository at [1] and use the example
> >>> script provided in README.md.
> >>>
> >>> [1] https://github.com/felipebalbi/omap-seeds
> >>>
> >>
> >> Ok, I pushed an updated branch named: for-4.2/ti-clk-move-v4
> >>
> >> This definitely compiles with OMAP2 / OMAP3 / OMAP4 / OMAP5 / DRA7 / A=
M33xx
> >> / AM43xx only setups (tried it out.)
> >
> > Thanks yeah seems to work for me now.
> >
> > Regards,
> >
> > Tony
> >
> =
> Question to Mike / Stephen, any chance of getting this in during the 4.2 =
> merge anymore seeing we are already at 4.1-rc6?
> =
> I can send a pull request if yes. Otherwise I just wait until we are =
> past the next merge.
Hi Tero,
I'd like more time for any regressions this introduces to be fixed, so
lets push back to next merge window. The always-wrong-but-never-by-much
crystal ball[0] predicts June 14. This is less than two weeks away, so
the wait should be short.
[0] http://phb-crystal-ball.org/
Thanks,
Mike
> =
> -Tero
next prev parent reply other threads:[~2015-06-03 23:11 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-25 15:00 [PATCHv3 00/27] ARM: OMAP2+: clock code move under clk driver Tero Kristo
2015-05-25 15:00 ` [PATCHv3 01/27] ARM: OMAP2+: clock: export driver API to setup/get clock features Tero Kristo
2015-05-28 22:04 ` Stephen Boyd
2015-06-02 10:22 ` Tero Kristo
2015-05-25 15:00 ` [PATCHv3 02/27] clk: ti: move generic OMAP DPLL implementation under drivers/clk Tero Kristo
2015-05-28 22:03 ` Stephen Boyd
2015-05-25 15:00 ` [PATCHv3 03/27] clk: ti: move OMAP4+ " Tero Kristo
2015-05-25 15:00 ` [PATCHv3 04/27] clk: ti: move interface clock " Tero Kristo
2015-05-25 15:00 ` [PATCHv3 05/27] ARM: OMAP3: dpll3-m2: get rid of obsolete clksel access Tero Kristo
2015-05-25 15:00 ` [PATCHv3 06/27] ARM: OMAP2+: clk: remove obsolete clksel support code Tero Kristo
2015-05-25 15:00 ` [PATCHv3 07/27] ARM: OMAP2+: clock: remove clock_common_data.c file Tero Kristo
2015-05-25 15:00 ` [PATCHv3 08/27] ARM: OMAP36xx: remove clock36xx.c/.h files Tero Kristo
2015-05-25 15:00 ` [PATCHv3 09/27] clk: ti: autoidle: move generic autoidle handling code to clock driver Tero Kristo
2015-05-25 15:00 ` [PATCHv3 10/27] clk: ti: move omap2_clk_enable_init_clocks under " Tero Kristo
2015-05-25 15:00 ` [PATCHv3 11/27] ARM: OMAP2+: clock: remove support for legacy mpurate command line param Tero Kristo
2015-05-25 15:00 ` [PATCHv3 12/27] ARM: OMAP2+: clock: add support for clkdm ops to the low level clk ops Tero Kristo
2015-05-25 15:00 ` [PATCHv3 13/27] ARM: OMAP2+: clock: add support for specific CM ops to ti_clk_ll_ops Tero Kristo
2015-05-25 15:00 ` [PATCHv3 14/27] clk: ti: dpll: move omap3 DPLL functionality to clock driver Tero Kristo
2015-05-25 15:00 ` [PATCHv3 15/27] ARM: OMAP3: clock: remove clock3xxx.c file Tero Kristo
2015-05-25 15:00 ` [PATCHv3 16/27] ARM: OMAP2+: clock: remove clkdm_control static boolean from code Tero Kristo
2015-05-25 15:00 ` [PATCHv3 17/27] clk: ti: dflt: move support for default gate clock to clock driver Tero Kristo
2015-05-25 15:00 ` [PATCHv3 18/27] clk: ti: omap2430: move clock support code under " Tero Kristo
2015-05-25 15:00 ` [PATCHv3 19/27] clk: ti: clkdm: move clkdm gate clock support code to " Tero Kristo
2015-05-25 15:00 ` [PATCHv3 20/27] clk: ti: omap34xx: move omap34xx clock type " Tero Kristo
2015-05-25 15:00 ` [PATCHv3 21/27] ARM: OMAP4: clock: remove clock44xx.h header Tero Kristo
2015-05-25 15:00 ` [PATCHv3 22/27] clk: ti: am3517: move remaining am3517 clock support code to clock driver Tero Kristo
2015-05-25 15:00 ` [PATCHv3 23/27] clk: ti: move some public definitions to private header Tero Kristo
2015-05-25 15:00 ` [PATCHv3 24/27] ARM: OMAP2+: clock: remove dead definitions from the clock header file Tero Kristo
2015-05-25 15:00 ` [PATCHv3 25/27] clk: ti: remove exported ll_ops struct, instead add an API for registration Tero Kristo
2015-05-25 15:00 ` [PATCHv3 26/27] ARM: OMAP2+: clock: remove legacy omap2_clk_readl/writel APIs Tero Kristo
2015-05-25 15:00 ` [PATCHv3 27/27] clk: ti: move low-level access and init code under clock driver Tero Kristo
2015-05-26 16:05 ` [PATCHv3 00/27] ARM: OMAP2+: clock code move under clk driver Tony Lindgren
2015-05-26 16:32 ` Tony Lindgren
2015-05-26 16:39 ` Felipe Balbi
2015-05-27 18:30 ` Tero Kristo
2015-05-27 23:15 ` Tony Lindgren
2015-06-03 12:33 ` Tero Kristo
2015-06-03 23:11 ` Michael Turquette [this message]
2015-06-04 5:26 ` Tero Kristo
2015-07-13 9:48 ` Tero Kristo
2015-07-13 20:26 ` Stephen Boyd
2015-05-26 17:41 ` Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150603231136.6017.65683@quantum \
--to=mturquette@linaro.org \
--cc=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=sboyd@codeaurora.org \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).