From: Dan Carpenter <dan.carpenter@oracle.com>
To: thomas.ab@samsung.com
Cc: linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org
Subject: re: clk: samsung: add infrastructure to register cpu clocks
Date: Fri, 26 Jun 2015 12:54:44 +0300 [thread overview]
Message-ID: <20150626095444.GA30810@mwanda> (raw)
Hello Thomas Abraham,
The patch ddeac8d968d4: "clk: samsung: add infrastructure to register
cpu clocks" from Apr 3, 2015, leads to the following static checker
warning:
drivers/clk/samsung/clk-cpu.c:164 exynos_cpuclk_pre_rate_change()
warn: test_bit() takes a bit number
drivers/clk/samsung/clk-cpu.c
158 /*
159 * For the selected PLL clock frequency, get the pre-defined divider
160 * values. If the clock for sclk_hpm is not sourced from apll, then
161 * the values for DIV_COPY and DIV_HPM dividers need not be set.
162 */
163 div0 = cfg_data->div0;
164 if (test_bit(CLK_CPU_HAS_DIV1, &cpuclk->flags)) {
^^^^^^^^^^^^^^^^
CLK_CPU_HAS_DIV1 is (1 << 0). We sometimes used it correctly as a mask
and sometimes incorrectly (like here) as a bit number.
165 div1 = cfg_data->div1;
166 if (readl(base + E4210_SRC_CPU) & E4210_MUX_HPM_MASK)
167 div1 = readl(base + E4210_DIV_CPU1) &
168 (E4210_DIV1_HPM_MASK | E4210_DIV1_COPY_MASK);
169 }
regards,
dan carpenter
next reply other threads:[~2015-06-26 9:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-26 9:54 Dan Carpenter [this message]
2015-06-26 10:03 ` clk: samsung: add infrastructure to register cpu clocks Krzysztof Kozlowski
2015-06-26 10:20 ` Bartlomiej Zolnierkiewicz
2015-06-26 10:47 ` Dan Carpenter
2015-06-26 11:06 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150626095444.GA30810@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=thomas.ab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox