From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Mike Turquette <mturquette@baylibre.com>,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Gregory CLEMENT <gregory.clement@free-electrons.com>,
Jason Cooper <jason@lakedaemon.net>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH 18/45] clk: mvebu: Remove clk.h include
Date: Mon, 20 Jul 2015 10:39:25 +0200 [thread overview]
Message-ID: <20150720103925.4466345f@bbrezillon> (raw)
In-Reply-To: <1436571223-10959-19-git-send-email-sboyd@codeaurora.org>
Adding the mvebu maintainers in Cc.
On Fri, 10 Jul 2015 16:33:16 -0700
Stephen Boyd <sboyd@codeaurora.org> wrote:
> Clock provider drivers generally shouldn't include clk.h because
> it's the consumer API. Only include the header if necessary. The
> clkdev.h include isn't used here either, so drop it and add in
> slab.h to keep things compiling.
>
> Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
> drivers/clk/mvebu/clk-cpu.c | 3 ++-
> drivers/clk/mvebu/common.c | 2 +-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/mvebu/clk-cpu.c b/drivers/clk/mvebu/clk-cpu.c
> index 3821a88077ea..86888a658d4c 100644
> --- a/drivers/clk/mvebu/clk-cpu.c
> +++ b/drivers/clk/mvebu/clk-cpu.c
> @@ -10,7 +10,8 @@
> * warranty of any kind, whether express or implied.
> */
> #include <linux/kernel.h>
> -#include <linux/clkdev.h>
> +#include <linux/slab.h>
> +#include <linux/clk.h>
> #include <linux/clk-provider.h>
> #include <linux/of_address.h>
> #include <linux/io.h>
> diff --git a/drivers/clk/mvebu/common.c b/drivers/clk/mvebu/common.c
> index 15b370ff3748..4a22429cd7a2 100644
> --- a/drivers/clk/mvebu/common.c
> +++ b/drivers/clk/mvebu/common.c
> @@ -13,8 +13,8 @@
> */
>
> #include <linux/kernel.h>
> +#include <linux/slab.h>
> #include <linux/clk.h>
> -#include <linux/clkdev.h>
> #include <linux/clk-provider.h>
> #include <linux/io.h>
> #include <linux/of.h>
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-07-20 8:39 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-10 23:32 [PATCH 00/45] Remove clk.h from clk-provider.h (clk drivers part) Stephen Boyd
2015-07-10 23:32 ` [PATCH 01/45] clk: axi-clkgen: Remove clk.h include Stephen Boyd
2015-07-10 23:33 ` [PATCH 02/45] clk: cdce706: Include clk.h Stephen Boyd
2015-07-10 23:33 ` [PATCH 03/45] clk: clps711x: Remove clk.h include Stephen Boyd
2015-07-10 23:33 ` [PATCH 04/45] clk: efm32gg: " Stephen Boyd
2015-07-11 17:24 ` Uwe Kleine-König
2015-07-10 23:33 ` [PATCH 05/45] clk: mux: " Stephen Boyd
2015-07-10 23:33 ` [PATCH 06/45] clk: nomadik: Remove clk.h and clkdev.h includes Stephen Boyd
2015-07-16 13:27 ` Linus Walleij
2015-07-10 23:33 ` [PATCH 07/45] clk: palmas: Remove " Stephen Boyd
2015-07-10 23:33 ` [PATCH 08/45] clk: rk808: Remove clk.h include Stephen Boyd
2015-07-10 23:33 ` [PATCH 09/45] clk: si5351: Include clk.h Stephen Boyd
2015-07-10 23:33 ` [PATCH 10/45] clk: twl6040: Remove clk.h include Stephen Boyd
2015-07-10 23:33 ` [PATCH 11/45] clk: u300: " Stephen Boyd
2015-07-16 13:28 ` Linus Walleij
2015-07-10 23:33 ` [PATCH 12/45] clk: wm831x: " Stephen Boyd
2015-07-10 23:33 ` [PATCH 13/45] clk: hisilicon: " Stephen Boyd
2015-07-10 23:33 ` [PATCH 14/45] clk: keystone: " Stephen Boyd
2015-07-10 23:33 ` [PATCH 15/45] clk: mediatek: Properly include clk.h Stephen Boyd
2015-07-10 23:33 ` [PATCH 16/45] clk: meson8b: " Stephen Boyd
2015-07-10 23:33 ` [PATCH 17/45] clk: mmp: Remove clk.h include Stephen Boyd
2015-07-10 23:33 ` [PATCH 18/45] clk: mvebu: " Stephen Boyd
2015-07-20 8:39 ` Boris Brezillon [this message]
2015-07-10 23:33 ` [PATCH 19/45] clk: mxs: Include clk.h in C files that use it Stephen Boyd
2015-07-12 2:47 ` Shawn Guo
2015-07-10 23:33 ` [PATCH 20/45] clk: nxp: Remove clk.h include Stephen Boyd
2015-07-11 7:24 ` Joachim Eastwood
2015-07-10 23:33 ` [PATCH 21/45] clk: rockchip: Properly include clk.h Stephen Boyd
2015-07-10 23:33 ` [PATCH 22/45] clk: samsung: Properly include clk.h and clkdev.h Stephen Boyd
2015-07-11 7:07 ` Krzysztof Kozlowski
2015-07-13 20:42 ` Stephen Boyd
2015-07-13 23:46 ` Krzysztof Kozlowski
2015-07-18 18:06 ` Paul Gortmaker
2015-07-10 23:33 ` [PATCH 23/45] clk: sirf: Properly include clk.h Stephen Boyd
2015-07-10 23:33 ` [PATCH 24/45] clk: socfpga: Remove clk.h and clkdev.h includes Stephen Boyd
2015-07-13 16:01 ` Dinh Nguyen
2015-07-10 23:33 ` [PATCH 25/45] clk: socfpga: Remove clk.h include Stephen Boyd
2015-07-13 2:33 ` Viresh Kumar
2015-07-10 23:33 ` [PATCH 26/45] clk: tegra: Properly include clk.h Stephen Boyd
2015-07-10 23:33 ` [PATCH 27/45] clk: ux500: Remove clk.h and clkdev.h includes Stephen Boyd
2015-07-16 13:29 ` Linus Walleij
2015-07-20 11:21 ` Ulf Hansson
2015-07-10 23:33 ` [PATCH 28/45] clk: versatile: " Stephen Boyd
2015-07-16 13:28 ` Linus Walleij
2015-07-10 23:33 ` [PATCH 29/45] clk: bcm: Include clk.h Stephen Boyd
2015-07-13 12:44 ` Alex Elder
2015-07-10 23:33 ` [PATCH 30/45] clk: highbank: " Stephen Boyd
2015-07-10 23:33 ` [PATCH 31/45] clk: qcom: " Stephen Boyd
2015-07-10 23:33 ` [PATCH 32/45] clk: st: " Stephen Boyd
2015-07-10 23:33 ` [PATCH 33/45] clk: sunxi: " Stephen Boyd
2015-07-20 8:01 ` Maxime Ripard
2015-07-20 18:01 ` Stephen Boyd
2015-07-27 7:33 ` Maxime Ripard
2015-07-10 23:33 ` [PATCH 34/45] clk: ti: " Stephen Boyd
2015-07-13 9:38 ` Tero Kristo
2015-07-10 23:33 ` [PATCH 35/45] clk: zynq: " Stephen Boyd
2015-07-13 16:54 ` Sören Brinkmann
2015-07-10 23:33 ` [PATCH 36/45] clk: Include clk.h in clk.c Stephen Boyd
2015-07-10 23:33 ` [PATCH 37/45] clk: cdce925: Include clk.h Stephen Boyd
2015-07-10 23:33 ` [PATCH 38/45] clk: moxart: " Stephen Boyd
2015-07-10 23:33 ` [PATCH 39/45] clk: si570: " Stephen Boyd
2015-07-13 16:55 ` Sören Brinkmann
2015-07-10 23:33 ` [PATCH 40/45] clk: ingenic: " Stephen Boyd
2015-07-10 23:33 ` [PATCH 41/45] clk: pistachio: " Stephen Boyd
2015-07-10 23:33 ` [PATCH 42/45] clk: samsung: s5pv210-audss: " Stephen Boyd
2015-07-10 23:33 ` [PATCH 43/45] clk: ti: Switch clk-provider.h include to clk.h Stephen Boyd
2015-07-13 9:38 ` Tero Kristo
2015-07-10 23:33 ` [PATCH 44/45] clk: at91: Include clk.h and slab.h Stephen Boyd
2015-07-20 8:36 ` Boris Brezillon
2015-07-10 23:33 ` [PATCH 45/45] clk: Remove clk.h from clk-provider.h Stephen Boyd
2015-07-18 18:17 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150720103925.4466345f@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=andrew@lunn.ch \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).