From: Stephen Boyd <sboyd@codeaurora.org>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: mturquette@baylibre.com,
Boris Brezillon <boris.brezillon@free-electrons.com>,
romain.perier@gmail.com, linux-clk@vger.kernel.org
Subject: Re: [PATCH] clk: handle fixed-rate clocks correctly in clk_core_round_rate_nolock
Date: Tue, 28 Jul 2015 14:34:34 -0700 [thread overview]
Message-ID: <20150728213434.GD14521@codeaurora.org> (raw)
In-Reply-To: <110607065.NoWaKp3mDJ@diego>
On 07/26, Heiko Stübner wrote:
> Commit 6edc753d8ecc ("clk: change clk_ops' ->determine_rate() prototype")
> changed the behaviour of clk_core_round_rate_nolock as it forgot to also
> include the else conditional simply returning the clock rate for clocks
> that neither have a parent or can determine their rate - for example
> said fixed clocks.
>
> This resulted in failures to set pll rates on rockchip socs, as it
> returned the target pll rate as suitable rate for the 24MHz xin24m clock,
> thus making the ccf want to set this fixed clock to 1.6GHz or similar.
>
> Fixes: 6edc753d8ecc ("clk: change clk_ops' ->determine_rate() prototype")
> Reported-by: Romain Perier <romain.perier@gmail.com>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
Thanks I folded this into the original patch and pushed it out to
-next.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
prev parent reply other threads:[~2015-07-28 21:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-25 22:18 [PATCH] clk: handle fixed-rate clocks correctly in clk_core_round_rate_nolock Heiko Stübner
2015-07-26 7:27 ` Boris Brezillon
2015-07-26 12:16 ` Romain Perier
2015-07-28 21:34 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150728213434.GD14521@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=boris.brezillon@free-electrons.com \
--cc=heiko@sntech.de \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=romain.perier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).