From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 18 Sep 2015 14:19:26 +0200 From: Maxime Ripard To: Chen-Yu Tsai Cc: Mike Turquette , Stephen Boyd , linux-arm-kernel , Hans de Goede , linux-clk , linux-kernel , linux-sunxi Subject: Re: [PATCH 2/5] ARM: sun5i: Add R8 DTSI Message-ID: <20150918121926.GP4684@lukather> References: <1442566130-3497-1-git-send-email-maxime.ripard@free-electrons.com> <1442566130-3497-3-git-send-email-maxime.ripard@free-electrons.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ibhTSt8h7StI2D+z" In-Reply-To: List-ID: --ibhTSt8h7StI2D+z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 18, 2015 at 05:41:47PM +0800, Chen-Yu Tsai wrote: > Hi, >=20 > On Fri, Sep 18, 2015 at 4:48 PM, Maxime Ripard > wrote: > > The R8 is very close to the A13, but it still has a few differences, > > notably a composite output, which the A13 lacks. > > > > Add a DTSI based on the A13's to hold those differences. > > > > Signed-off-by: Maxime Ripard > > --- > > arch/arm/boot/dts/sun5i-r8.dtsi | 61 +++++++++++++++++++++++++++++++++= ++++++++ > > 1 file changed, 61 insertions(+) > > create mode 100644 arch/arm/boot/dts/sun5i-r8.dtsi > > > > diff --git a/arch/arm/boot/dts/sun5i-r8.dtsi b/arch/arm/boot/dts/sun5i-= r8.dtsi > > new file mode 100644 > > index 000000000000..c9ed854687ca > > --- /dev/null > > +++ b/arch/arm/boot/dts/sun5i-r8.dtsi > > @@ -0,0 +1,61 @@ > > +/* > > + * Copyright 2015 Free Electrons > > + * Copyright 2015 NextThing Co > > + * > > + * Maxime Ripard > > + * > > + * This file is dual-licensed: you can use it either under the terms > > + * of the GPL or the X11 license, at your option. Note that this dual > > + * licensing only applies to this file, and not this project as a > > + * whole. > > + * > > + * a) This file is free software; you can redistribute it and/or > > + * modify it under the terms of the GNU General Public License as > > + * published by the Free Software Foundation; either version 2 of = the > > + * License, or (at your option) any later version. > > + * > > + * This file is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + * GNU General Public License for more details. > > + * > > + * Or, alternatively, > > + * > > + * b) Permission is hereby granted, free of charge, to any person > > + * obtaining a copy of this software and associated documentation > > + * files (the "Software"), to deal in the Software without > > + * restriction, including without limitation the rights to use, > > + * copy, modify, merge, publish, distribute, sublicense, and/or > > + * sell copies of the Software, and to permit persons to whom the > > + * Software is furnished to do so, subject to the following > > + * conditions: > > + * > > + * The above copyright notice and this permission notice shall be > > + * included in all copies or substantial portions of the Software. > > + * > > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > > + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES > > + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND > > + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT > > + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, > > + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING > > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR > > + * OTHER DEALINGS IN THE SOFTWARE. > > + */ > > + > > +#include "skeleton.dtsi" >=20 > This is already included by sun5i.dtsi, which is included by > sun5i-a13.dtsi. Ah, yes. > > + > > +#include "sun5i-a13.dtsi" > > + > > +/ { > > + chosen { > > + framebuffer@1 { > > + compatible =3D "allwinner,simple-framebuffer", > > + "simple-framebuffer"; > > + allwinner,pipeline =3D "de_be0-lcd0-tve0"; > > + clocks =3D <&pll5 1>, <&ahb_gates 34>, <&ahb_ga= tes 36>, > > + <&ahb_gates 44>; > > + status =3D "disabled"; > > + }; > > + }; > > +}; > > -- > > 2.5.1 > > >=20 > The rest looks good. >=20 > Reviewed-by: Chen-Yu Tsai Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --ibhTSt8h7StI2D+z Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJV/AFOAAoJEBx+YmzsjxAgjuoQAI+cP6pBu9LyHr96zAk+Yoca GzFxgELryMtDWLwjuKQJuEhyqokZDpZhRW28z9noqMwxmdDJb9HdMuq6fGUZ4wls vUWmS/FRdbAp+5z8UAPLptgbPNwwJJAc02vW/nXJsp0/iRYlKJudSnqS2Z5NWitr A75y3wz/BOImBMhv6sBrtpMObRdUj5mrx9z1OA1+Q5vOaHUKT5+SYCdQEoOpJ6tv Izn6LlYvFILZKDFJ1W+behgIVsjU+jchWn8k7hirZsY3DnHINSqAuxlM1yxhyDIr T7wmhBBDuZXq+KIXXntz/j6wTX6aGF7fVBCyOOrPkMHvRj4vJBaSoZeXHTYw7bTs 8EEfj7cB13VPt2bHrGfYzZi75p62gEvNYHiNGe8D+7Er66OdBdSTKj8Jy91dUZbK Vs4Vb3xjLcl/aOtTWPLqc5fLKiYt8e+ThCJUlNvSnWM4OunGQWd4NuPfQnKwwiah aGoWvqRFaVNxrRofuUME02OiEmqeBUFb7wvhyrJIn9MMpjIHdW0fk8XSy72Bjd51 xl5+ZW3O8+MwuBnq6ssxaotKmcmnfBG2NckLJsrebAsdH4RBlZGXXssahAbQlzc5 ECqxOytAPsaOShVgeBlyxBet68M8NKTF7dwlWYIpBOtXsHBjsDx+DouqidC1MfOS uY8D2EaijOu2GPa+iZOd =GEfB -----END PGP SIGNATURE----- --ibhTSt8h7StI2D+z--