From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 1 Oct 2015 11:03:57 -0700 From: Stephen Boyd To: Paul Osmialowski Cc: Michael Turquette , Russell King , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/1] add devm_of_clk_get() and devm_of_clk_get_by_name() functions Message-ID: <20151001180357.GG19319@codeaurora.org> References: <1443081808-19688-1-git-send-email-newchief@king.net.pl> <20150928230523.GR23081@codeaurora.org> <20150930220415.GD18556@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: List-ID: On 10/01, Paul Osmialowski wrote: > Hi Stephen, > > On Wed, 30 Sep 2015, Stephen Boyd wrote: > > > In the pinctrl node we would have > > > > pinctrl { > > compatible = "fsl,kenetis70-pinctrl"; > > reg = <0x40049000 0x2000>; > > clocks = <&sim SIM_CLK_SCGC5_PORTA>, <&sim SIM_CLK_SCGC5_PORTB>; > > > > uart_default: uart_default { > > mux { > > pins = "porta_3", "portb_2"; > > function = "uart"; > > }; > > > > rx { > > bias-pull-pin-default; > > }; > > }; > > }; > > > > And then in the uart node we would have > > > > uart@f00000 { > > compatible = "vendor,uart"; > > reg = <0xf00000 0x100>; > > pinctrl-names = "default"; > > pinctrl-0 = <&uart_default>; > > }; > > > > Seems like there's another thing I wanted to avoid. The correctness of > these pin strings will not be checked until the runtime. They need to > properly encode pin bank and pin number within the bank. No chances it can > be validated at .dtb build time. But I guess this is proper way for > generic pinctrl bindings. I mostly (but not completely) based my approach > on rockchip examples (e.g. rk3288) but it looks like they are not entirely > sane. I don't see how it could be validated with the <&port pin function config> binding either. Let's hope that people test their code, including whatever dts files they produce. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project