* [PATCH] clk: Make clk input parameter of __clk_get_name() const
@ 2015-10-16 12:35 Geert Uytterhoeven
2015-10-16 18:57 ` Stephen Boyd
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2015-10-16 12:35 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd
Cc: linux-clk, linux-kernel, Geert Uytterhoeven
When calling __clk_get_name() on a const clock:
warning: passing argument 1 of '__clk_get_name' discards 'const' qualifier from pointer target type
include/linux/clk-provider.h:613:13: note: expected 'struct clk *' but argument is of type 'const struct clk *'
__clk_get_name() does not modify the passed clock, hence make it const.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/clk/clk.c | 2 +-
include/linux/clk-provider.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index b005f666e3a1a716..a8c59aee9eedf7e1 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -272,7 +272,7 @@ late_initcall_sync(clk_disable_unused);
/*** helper functions ***/
-const char *__clk_get_name(struct clk *clk)
+const char *__clk_get_name(const struct clk *clk)
{
return !clk ? NULL : clk->core->name;
}
diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h
index 8ff43eb4b3113a12..bbb8fed11e4479b2 100644
--- a/include/linux/clk-provider.h
+++ b/include/linux/clk-provider.h
@@ -607,7 +607,7 @@ void clk_unregister(struct clk *clk);
void devm_clk_unregister(struct device *dev, struct clk *clk);
/* helper functions */
-const char *__clk_get_name(struct clk *clk);
+const char *__clk_get_name(const struct clk *clk);
const char *clk_hw_get_name(const struct clk_hw *hw);
struct clk_hw *__clk_get_hw(struct clk *clk);
unsigned int clk_hw_get_num_parents(const struct clk_hw *hw);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] clk: Make clk input parameter of __clk_get_name() const
2015-10-16 12:35 [PATCH] clk: Make clk input parameter of __clk_get_name() const Geert Uytterhoeven
@ 2015-10-16 18:57 ` Stephen Boyd
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Boyd @ 2015-10-16 18:57 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Michael Turquette, linux-clk, linux-kernel
On 10/16, Geert Uytterhoeven wrote:
> When calling __clk_get_name() on a const clock:
>
> warning: passing argument 1 of '__clk_get_name' discards 'const' qualifier from pointer target type
> include/linux/clk-provider.h:613:13: note: expected 'struct clk *' but argument is of type 'const struct clk *'
>
> __clk_get_name() does not modify the passed clock, hence make it const.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
Applied to clk-next.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-16 18:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-16 12:35 [PATCH] clk: Make clk input parameter of __clk_get_name() const Geert Uytterhoeven
2015-10-16 18:57 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).