From: Andy Gross <agross@codeaurora.org>
To: Georgi Djakov <georgi.djakov@linaro.org>
Cc: sboyd@codeaurora.org, mturquette@baylibre.com,
linux-clk@vger.kernel.org, bjorn.andersson@sonymobile.com,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v3 1/8] arm64: dts: qcom: 8x16: Add fixed rate on-board oscillator
Date: Wed, 21 Oct 2015 21:52:07 -0500 [thread overview]
Message-ID: <20151022025207.GB4968@qualcomm.com> (raw)
In-Reply-To: <1445360280-2347-2-git-send-email-georgi.djakov@linaro.org>
On Tue, Oct 20, 2015 at 07:57:53PM +0300, Georgi Djakov wrote:
> Add the on-board XO oscillator. This patch prepares for adding support
> for RPM controlled clocks. In order to do smooth transition and support
> both cases (RPM clock driver is enabled or nor), we first move the XO to
> the DT and change the GCC fixed-rate root clock to a dummy pass-through
> clock. Then if the RPM driver is enabled, we set the parent of the XO
> clock in the RPM clock driver to xo_board.
> The advantage of doing so is that the rate of the XO clock is not hard-
> coded in the GCC driver anymore, but comes from the board layout, so
> that is why it should be in DT anyway.
>
> Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
> ---
Looks good to me.
Reviewed-by: Andy Gross <agross@codeaurora.org>
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-10-22 2:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 16:57 [PATCH v3 0/8] Add initial support for RPM clocks Georgi Djakov
2015-10-20 16:57 ` [PATCH v3 1/8] arm64: dts: qcom: 8x16: Add fixed rate on-board oscillator Georgi Djakov
2015-10-22 2:52 ` Andy Gross [this message]
2015-10-27 23:17 ` Stephen Boyd
2015-10-20 16:57 ` [PATCH v3 2/8] clk: qcom: msm8916: Set the parent of xo to xo_board Georgi Djakov
2015-10-26 22:43 ` Stephen Boyd
2015-10-20 16:57 ` [PATCH v3 3/8] clk: qcom: msm8916: Ignore sleep_clk_src registration errors Georgi Djakov
2015-10-26 22:44 ` Stephen Boyd
2015-10-20 16:57 ` [PATCH v3 4/8] arm64: dts: qcom: 8x16: Add fixed rate sleep clock oscillator Georgi Djakov
2015-10-20 16:57 ` [PATCH v3 5/8] clk: qcom: Add support for RPM Clocks Georgi Djakov
2015-10-27 23:15 ` Stephen Boyd
2015-10-20 16:57 ` [PATCH v3 6/8] clk: qcom: Add RPM clock controller driver Georgi Djakov
2015-10-27 23:23 ` Stephen Boyd
2015-10-20 16:57 ` [PATCH v3 7/8] clk: qcom: msm8916: Use RPMCC if it is enabled Georgi Djakov
2015-10-20 16:58 ` [PATCH v3 8/8] clk: qcom: msm8916: Remove hard-coded sleep_clk_src Georgi Djakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151022025207.GB4968@qualcomm.com \
--to=agross@codeaurora.org \
--cc=bjorn.andersson@sonymobile.com \
--cc=georgi.djakov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).