* [PATCH] clk: versatile-icst: fix memory leak
@ 2015-10-23 9:36 Linus Walleij
2015-10-23 16:20 ` Stephen Boyd
0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2015-10-23 9:36 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd; +Cc: linux-clk, Linus Walleij
A static code checker found a memory leak in the Versatile
ICST code. Fix it.
Fixes: a183da637c52 "clk: versatile: respect parent rate in ICST clock"
Reported-by: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/clk/versatile/clk-icst.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/versatile/clk-icst.c b/drivers/clk/versatile/clk-icst.c
index a3893ea2199d..08c5ee976879 100644
--- a/drivers/clk/versatile/clk-icst.c
+++ b/drivers/clk/versatile/clk-icst.c
@@ -157,8 +157,10 @@ struct clk *icst_clk_register(struct device *dev,
icst->lockreg = base + desc->lock_offset;
clk = clk_register(dev, &icst->hw);
- if (IS_ERR(clk))
+ if (IS_ERR(clk)) {
+ kfree(pclone);
kfree(icst);
+ }
return clk;
}
--
2.4.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] clk: versatile-icst: fix memory leak
2015-10-23 9:36 [PATCH] clk: versatile-icst: fix memory leak Linus Walleij
@ 2015-10-23 16:20 ` Stephen Boyd
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Boyd @ 2015-10-23 16:20 UTC (permalink / raw)
To: Linus Walleij; +Cc: Michael Turquette, linux-clk
On 10/23, Linus Walleij wrote:
> A static code checker found a memory leak in the Versatile
> ICST code. Fix it.
>
> Fixes: a183da637c52 "clk: versatile: respect parent rate in ICST clock"
> Reported-by: Stephen Boyd <sboyd@codeaurora.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
Applied to clk-next
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-23 16:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-23 9:36 [PATCH] clk: versatile-icst: fix memory leak Linus Walleij
2015-10-23 16:20 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).