From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Date: Mon, 26 Oct 2015 14:29:30 +0000 From: Lee Jones To: Alim Akhtar Cc: broonie@kernel.org, k.kozlowski@samsung.com, mturquette@baylibre.com, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, Thomas Abraham Subject: Re: [PATCH v2 2/5] mfd: sec: Add support for S2MPS15 PMIC Message-ID: <20151026142930.GJ597@x1> References: <1445855803-26973-1-git-send-email-alim.akhtar@samsung.com> <1445855803-26973-3-git-send-email-alim.akhtar@samsung.com> <20151026110611.GH597@x1> <562E1F84.2000105@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: <562E1F84.2000105@samsung.com> List-ID: On Mon, 26 Oct 2015, Alim Akhtar wrote: > Hi Lee, > Thanks for looking into this. > > On 10/26/2015 04:36 PM, Lee Jones wrote: > >On Mon, 26 Oct 2015, Alim Akhtar wrote: > > > >>From: Thomas Abraham > >> > >>Add support for S2MPS15 PMIC which is similar to S2MPS11 PMIC. The S2MPS15 > >>PMIC supports 27 LDO regulators, 10 buck regulators, RTC, three 32.768KHz > >>clock outputs and battery charger. This patch adds initial support for > >>LDO and buck regulators of S2MPS15 device. > >> > >>Signed-off-by: Thomas Abraham > >>Signed-off-by: Alim Akhtar > >>[Alim: Added s2mps15_devs like rtc and clk and related changes] > >>Reviewed-by: Krzysztof Kozlowski > >>--- > >> drivers/mfd/sec-core.c | 31 +++++++ > >> drivers/mfd/sec-irq.c | 8 ++ > >> include/linux/mfd/samsung/core.h | 1 + > >> include/linux/mfd/samsung/s2mps15.h | 161 +++++++++++++++++++++++++++++++++++ > >> 4 files changed, 201 insertions(+) > >> create mode 100644 include/linux/mfd/samsung/s2mps15.h > >> > >>diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c > >>index 2626fc0b5b8c..db3d4d4ff805 100644 > >>--- a/drivers/mfd/sec-core.c > >>+++ b/drivers/mfd/sec-core.c > >>@@ -29,6 +29,7 @@ > >> #include > >> #include > >> #include > >>+#include > >> #include > >> #include > >> #include > >>@@ -96,6 +97,17 @@ static const struct mfd_cell s2mps14_devs[] = { > >> } > >> }; > >> > >>+static const struct mfd_cell s2mps15_devs[] = { > >>+ { > >>+ .name = "s2mps15-pmic", > >>+ }, { > >>+ .name = "s2mps15-rtc", > >>+ }, { > > > >Why don't these have compatibles? > > > s2mps15-pmic does have compatible below in sec_dt_match[]. Woah!! What's going on here? You're matching the MFD and Regulator drivers with the same compatible string. And then registering the Regulator device as an MFD. That's a bit confusing don't you think? > s2mps15-rtc does not need one as rtc driver does not support OF yet. > So no DT node for this as of now. [...] -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog