From: Mark Brown <broonie@kernel.org>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
linux-pwm@vger.kernel.org,
Mike Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
linux-clk@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Kamil Debski <k.debski@samsung.com>,
lm-sensors@lm-sensors.org, Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, Bryan Wu <cooloney@gmail.com>,
Richard Purdie <rpurdie@rpsys.net>,
Jacek Anaszewski <j.anaszewski@samsung.com>,
linux-leds@vger.kernel.org,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Chen-Yu Tsai <wens@csie.org>,
linux-sunxi@googlegroups.com,
Joachim Eastwood <manabian@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Heiko Stuebner <heiko@sntech.de>,
linux-rockchip@lists.infradead.org,
Jingoo Han <jingoohan1@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
linux-fbdev@vger.kernel.org,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 09/24] regulator: pwm: use pwm_get/set_default_xxx() helpers where appropriate
Date: Mon, 16 Nov 2015 10:55:58 +0000 [thread overview]
Message-ID: <20151116105558.GB31303@sirena.org.uk> (raw)
In-Reply-To: <1447664207-24370-10-git-send-email-boris.brezillon@free-electrons.com>
[-- Attachment #1: Type: text/plain, Size: 651 bytes --]
On Mon, Nov 16, 2015 at 09:56:32AM +0100, Boris Brezillon wrote:
> +++ b/drivers/regulator/pwm-regulator.c
> @@ -56,7 +56,7 @@ static int pwm_regulator_set_voltage_sel(struct regulator_dev *rdev,
> int dutycycle;
> int ret;
>
> - pwm_reg_period = pwm_get_period(drvdata->pwm);
> + pwm_reg_period = pwm_get_default_period(drvdata->pwm);
>
> dutycycle = (pwm_reg_period *
> drvdata->duty_cycle_table[selector].dutycycle) / 100;
It's not clear to me that we're not looking for the current period here
or in the other use. Won't configuring based on a period other than the
one that has been set give the wrong answer?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-11-16 10:55 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 8:56 [PATCH v4 00/24] pwm: add support for atomic update Boris Brezillon
2015-11-16 8:56 ` [PATCH v4 01/24] pwm: rcar: make use of pwm_is_enabled() Boris Brezillon
2016-03-16 14:30 ` Boris Brezillon
2015-11-16 8:56 ` [PATCH v4 02/24] pwm: use pwm_get_xxx() helpers where appropriate Boris Brezillon
2015-11-16 17:46 ` Joachim Eastwood
2015-11-16 18:06 ` Boris Brezillon
2015-11-16 8:56 ` [PATCH v4 03/24] clk: " Boris Brezillon
2015-12-30 21:03 ` Michael Turquette
2015-11-16 8:56 ` [PATCH v4 04/24] hwmon: pwm-fan: " Boris Brezillon
2015-11-16 15:59 ` Guenter Roeck
2015-11-16 16:53 ` Boris Brezillon
2015-11-16 17:00 ` Guenter Roeck
2015-11-16 8:56 ` [PATCH v4 05/24] misc: max77693-haptic: " Boris Brezillon
2015-11-16 13:10 ` Krzysztof Kozlowski
2015-11-16 13:55 ` Boris Brezillon
2015-11-16 15:55 ` Guenter Roeck
2015-11-16 16:00 ` Boris Brezillon
2015-11-17 17:32 ` Dmitry Torokhov
2015-11-16 8:56 ` [PATCH v4 06/24] pwm: introduce default period and polarity concepts Boris Brezillon
2015-11-16 8:56 ` [PATCH v4 07/24] pwm: use pwm_get/set_default_xxx() helpers where appropriate Boris Brezillon
2015-11-16 8:56 ` [PATCH v4 08/24] leds: " Boris Brezillon
2015-11-16 8:56 ` [PATCH v4 09/24] regulator: " Boris Brezillon
2015-11-16 10:55 ` Mark Brown [this message]
2015-11-16 12:23 ` Boris Brezillon
2015-11-16 18:42 ` Mark Brown
2015-11-16 19:28 ` Boris Brezillon
2015-12-02 10:37 ` Boris Brezillon
2015-12-30 11:01 ` Boris Brezillon
2015-11-16 8:56 ` [PATCH v4 10/24] backlight: " Boris Brezillon
2015-11-16 8:56 ` [PATCH v4 11/24] fbdev: " Boris Brezillon
2015-11-16 8:56 ` [PATCH v4 12/24] misc: max77693: " Boris Brezillon
2015-11-16 8:56 ` [PATCH v4 13/24] hwmon: pwm-fan: " Boris Brezillon
2015-11-16 16:00 ` Guenter Roeck
2015-11-16 8:56 ` [PATCH v4 14/24] clk: pwm: " Boris Brezillon
2015-12-30 21:05 ` Michael Turquette
2015-11-16 8:56 ` [PATCH v4 15/24] pwm: define a new pwm_state struct Boris Brezillon
2015-11-16 8:56 ` [PATCH v4 16/24] pwm: move the enabled/disabled info to " Boris Brezillon
2015-11-16 8:56 ` [PATCH v4 17/24] backlight: pwm_bl: remove useless call to pwm_set_period Boris Brezillon
2015-11-16 8:56 ` [PATCH v4 18/24] pwm: declare a default PWM state Boris Brezillon
2015-11-16 8:56 ` [PATCH v4 19/24] pwm: add the PWM initial state retrieval infra Boris Brezillon
2015-11-16 8:56 ` [PATCH v4 20/24] pwm: add the core infrastructure to allow atomic update Boris Brezillon
2015-11-16 8:56 ` [PATCH v4 21/24] pwm: add information about polarity, duty cycle and period to debugfs Boris Brezillon
2015-11-16 8:56 ` [PATCH v4 22/24] pwm: rockchip: add initial state retrieval Boris Brezillon
2015-11-16 8:56 ` [PATCH v4 23/24] pwm: rockchip: add support for atomic update Boris Brezillon
2015-11-16 8:56 ` [PATCH v4 24/24] regulator: pwm: properly initialize the ->state field Boris Brezillon
2015-11-16 14:45 ` [PATCH v4 00/24] pwm: add support for atomic update Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151116105558.GB31303@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Julia.Lawall@lip6.fr \
--cc=alexandre.belloni@free-electrons.com \
--cc=boris.brezillon@free-electrons.com \
--cc=cooloney@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=heiko@sntech.de \
--cc=j.anaszewski@samsung.com \
--cc=jdelvare@suse.com \
--cc=jingoohan1@gmail.com \
--cc=k.debski@samsung.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
--cc=manabian@gmail.com \
--cc=maxime.ripard@free-electrons.com \
--cc=mturquette@baylibre.com \
--cc=plagnioj@jcrosoft.com \
--cc=robert.jarzmik@free.fr \
--cc=rpurdie@rpsys.net \
--cc=sboyd@codeaurora.org \
--cc=thierry.reding@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=tomi.valkeinen@ti.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox