From: "Mutharaju, Prasanna (P.)" <mkarthi3@visteon.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Kukjin Kim <kgene@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
"Michael Turquette" <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>
Subject: Re: [PATCH v2] clk: s3c2410: removed unneeded variable in s3c24xx_clkout_set_parent
Date: Mon, 30 Nov 2015 08:05:18 +0000 [thread overview]
Message-ID: <20151130080514.GA27761@jci-VirtualBox> (raw)
In-Reply-To: <565BFB57.2000701@samsung.com>
On Mon, Nov 30, 2015 at 04:31:35PM +0900, Krzysztof Kozlowski wrote:
> On 30.11.2015 16:28, Mutharaju, Prasanna (P.) wrote:
> > From: Prasanna Karthik <mkarthi3@visteon.com>
> >=20
> > Remove unneeded variable used to store return value.
> > V2: Modified subject =20
>=20
> Changelog (v2) should go after '---' separator so it won't get included
> in the commit message.
>=20
Done in v3.=20
> Now I see that you Signed-off-by is okay - same email address... I got
> confused by the difference in name.
Yeah, my gitconfig and outlook account differ little.=20
> Best regards,
> Krzysztof
> >=20
> > Signed-off-by: Prasanna Karthik <mkarthi3@visteon.com>
> > ---
> > drivers/clk/samsung/clk-s3c2410-dclk.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >=20
> > diff --git a/drivers/clk/samsung/clk-s3c2410-dclk.c b/drivers/clk/samsu=
ng/clk-s3c2410-dclk.c
> > index e9eb935..ec6fb14 100644
> > --- a/drivers/clk/samsung/clk-s3c2410-dclk.c
> > +++ b/drivers/clk/samsung/clk-s3c2410-dclk.c
> > @@ -77,12 +77,11 @@ static u8 s3c24xx_clkout_get_parent(struct clk_hw *=
hw)
> > static int s3c24xx_clkout_set_parent(struct clk_hw *hw, u8 index)
> > {
> > struct s3c24xx_clkout *clkout =3D to_s3c24xx_clkout(hw);
> > - int ret =3D 0;
> > =20
> > s3c2410_modify_misccr((clkout->mask << clkout->shift),
> > (index << clkout->shift));
> > =20
> > - return ret;
> > + return 0;
> > }
> > =20
> > static const struct clk_ops s3c24xx_clkout_ops =3D {
> >=20
> =
prev parent reply other threads:[~2015-11-30 8:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-30 7:28 [PATCH v2] clk: s3c2410: removed unneeded variable in s3c24xx_clkout_set_parent Mutharaju, Prasanna (P.)
2015-11-30 7:31 ` Krzysztof Kozlowski
2015-11-30 8:05 ` Mutharaju, Prasanna (P.) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151130080514.GA27761@jci-VirtualBox \
--to=mkarthi3@visteon.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@codeaurora.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox