* [PATCH] clk: sunxi: fix handling return value of of_property_match_string
[not found] <1450087564-28441-1-git-send-email-a.hajda@samsung.com>
@ 2015-12-14 10:06 ` Andrzej Hajda
2015-12-14 13:05 ` Maxime Ripard
0 siblings, 1 reply; 2+ messages in thread
From: Andrzej Hajda @ 2015-12-14 10:06 UTC (permalink / raw)
To: Emilio López
Cc: Andrzej Hajda, Bartlomiej Zolnierkiewicz, Marek Szyprowski,
Michael Turquette, Stephen Boyd, Maxime Ripard, Chen-Yu Tsai,
linux-clk, linux-arm-kernel, linux-kernel
The function can return negative values, so its result should
be assigned to signed variable.
The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].
[1]: http://permalink.gmane.org/gmane.linux.kernel/2046107
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
---
drivers/clk/sunxi/clk-sun8i-bus-gates.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/clk/sunxi/clk-sun8i-bus-gates.c b/drivers/clk/sunxi/clk-sun8i-bus-gates.c
index 7ab60c5..ecadd97 100644
--- a/drivers/clk/sunxi/clk-sun8i-bus-gates.c
+++ b/drivers/clk/sunxi/clk-sun8i-bus-gates.c
@@ -47,12 +47,12 @@ static void __init sun8i_h3_bus_gates_init(struct device_node *node)
return;
for (i = 0; i < ARRAY_SIZE(names); i++) {
- index = of_property_match_string(node, "clock-names",
- names[i]);
- if (index < 0)
+ int idx = of_property_match_string(node, "clock-names",
+ names[i]);
+ if (idx < 0)
return;
- parents[i] = of_clk_get_parent_name(node, index);
+ parents[i] = of_clk_get_parent_name(node, idx);
}
clk_data = kmalloc(sizeof(struct clk_onecell_data), GFP_KERNEL);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] clk: sunxi: fix handling return value of of_property_match_string
2015-12-14 10:06 ` [PATCH] clk: sunxi: fix handling return value of of_property_match_string Andrzej Hajda
@ 2015-12-14 13:05 ` Maxime Ripard
0 siblings, 0 replies; 2+ messages in thread
From: Maxime Ripard @ 2015-12-14 13:05 UTC (permalink / raw)
To: Andrzej Hajda
Cc: Emilio López, Bartlomiej Zolnierkiewicz, Marek Szyprowski,
Michael Turquette, Stephen Boyd, Chen-Yu Tsai, linux-clk,
linux-arm-kernel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 568 bytes --]
Hi,
On Mon, Dec 14, 2015 at 11:06:00AM +0100, Andrzej Hajda wrote:
> The function can return negative values, so its result should
> be assigned to signed variable.
>
> The problem has been detected using proposed semantic patch
> scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Applied, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-14 13:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1450087564-28441-1-git-send-email-a.hajda@samsung.com>
2015-12-14 10:06 ` [PATCH] clk: sunxi: fix handling return value of of_property_match_string Andrzej Hajda
2015-12-14 13:05 ` Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).