Re: [PATCH 06/14] ARM: dts: sun8i-a83t: Correct low speed oscillator clocks

Maxime Ripard
2016-02-02T13:18:51Z

[-- Attachment #1: Type: text/plain, Size: 1948 bytes --]

1;4002;0c
On Sun, Jan 31, 2016 at 09:20:58AM +0800, Vishnu Patekar wrote:
> From: Chen-Yu Tsai <wens@csie.org>
>
> The A83T does not have a 32.768 kHz low speed oscillator, either as
> an external crystal or input. It has a 16 MHz RC-based (inaccurate)
> internal oscillator, which is then divided by 512 for a clock close
> to 32 kHz.
>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> ---
> arch/arm/boot/dts/sun8i-a83t.dtsi | 21 ++++++++++++++++++---
> 1 file changed, 18 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi
> index 8d27b63..45b725c 100644
> --- a/arch/arm/boot/dts/sun8i-a83t.dtsi
> +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi
> @@ -118,6 +118,7 @@
> #size-cells = <1>;
> ranges;
>
> + /* TODO: PRCM block has a mux for this. */
> osc24M: osc24M_clk {
> #clock-cells = <0>;
> compatible = "fixed-clock";
> @@ -125,11 +126,25 @@
> clock-output-names = "osc24M";
> };
>
> - osc32k: osc32k_clk {
> + /*
> + * This is called "internal OSC" in some places.
> + * It is an internal RC-based oscillator.
> + * TODO: Its controls are in the PRCM block.
> + */
> + osc16M: osc16M_clk {
> #clock-cells = <0>;
> compatible = "fixed-clock";
> - clock-frequency = <32768>;
> - clock-output-names = "osc32k";
> + clock-frequency = <16000000>;
> + clock-output-names = "osc16M";
> + };
> +
> + osc16Md512: osc16Md512_clk {
> + #clock-cells = <0>;
> + compatible = "fixed-factor-clock";
> + clock-div = <512>;
> + clock-mult = <1>;
> + clocks = <&osc16M>;
> + clock-output-names = "osc16Md512";

We've been using a dash to separate between the clock and its divider
on other SoCs.

I changed that and applied the patch.

Thanks!
Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]