From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Vishnu Patekar <vishnupatekar0510@gmail.com>
Cc: robh+dt@kernel.org, corbet@lwn.net, pawel.moll@arm.com,
mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
galak@codeaurora.org, linux@arm.linux.org.uk,
emilio@elopez.com.ar, jenskuske@gmail.com, hdegoede@redhat.com,
wens@csie.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com,
linux-gpio@vger.kernel.org, linus.walleij@linaro.org,
mturquette@baylibre.com, sboyd@codeaurora.org,
patchesrdh@mveas.com, linux-clk@vger.kernel.org
Subject: Re: [PATCH 03/14] clk: sunxi: add bus gates for A83T
Date: Tue, 2 Feb 2016 14:13:47 +0100 [thread overview]
Message-ID: <20160202131347.GP4652@lukather> (raw)
In-Reply-To: <1454203266-4450-4-git-send-email-vishnupatekar0510@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1549 bytes --]
On Sun, Jan 31, 2016 at 09:20:55AM +0800, Vishnu Patekar wrote:
> A83T has similar bus gates that of H3, including single gating register has
> different clock parent.
>
> As per H3 and A83T datasheet, usbhost is under AHB2.
>
> However,below shows allwinner source code assignment:
> bits: 26 (ehci0), 27 (ehci1), 29 (ohci0) => AHB1 for A83T.
> bits: 26 (ehci0), 27 (ehci1) => AHB1 for H3
> bits 29, 30, 31(ohci0,1,2) => AHB2 for H3.
>
> until, this confusion is cleared keep it H3 way.
>
> Signed-off-by: Vishnu Patekar <vishnupatekar0510@gmail.com>
> ---
> Documentation/devicetree/bindings/clock/sunxi.txt | 1 +
> drivers/clk/sunxi/clk-sun8i-bus-gates.c | 2 ++
> 2 files changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/clock/sunxi.txt b/Documentation/devicetree/bindings/clock/sunxi.txt
> index 7f19ef5..4514d77 100644
> --- a/Documentation/devicetree/bindings/clock/sunxi.txt
> +++ b/Documentation/devicetree/bindings/clock/sunxi.txt
> @@ -59,6 +59,7 @@ Required properties:
> "allwinner,sun6i-a31-apb2-gates-clk" - for the APB2 gates on A31
> "allwinner,sun8i-a23-apb2-gates-clk" - for the APB2 gates on A23
> "allwinner,sun8i-h3-bus-gates-clk" - for the bus gates on H3
> + "allwinner,sun8i-a83t-bus-gates-clk" - for the bus gates on A83T
Please order them alphabetically next time.
Applied with the fix, and the Acked-bys
thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-02-02 13:13 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-31 1:20 [PATCH 00/14] Add A83T clk, r_pio, mmc rsb support Vishnu Patekar
2016-01-31 1:20 ` [PATCH 01/14] pinctrl: sunxi: Add A83T R_PIO controller support Vishnu Patekar
2016-02-01 15:00 ` Rob Herring
2016-02-11 11:59 ` Linus Walleij
2016-02-11 12:36 ` Maxime Ripard
2016-02-11 13:47 ` Linus Walleij
2016-02-11 15:12 ` Maxime Ripard
2016-02-15 23:23 ` Linus Walleij
2016-02-25 0:56 ` Maxime Ripard
2016-02-25 14:49 ` Linus Walleij
2016-01-31 1:20 ` [PATCH 02/14] clk: sunxi: Add apb0 gates for A83T Vishnu Patekar
2016-02-01 15:02 ` Rob Herring
2016-02-01 15:11 ` Chen-Yu Tsai
2016-02-02 13:12 ` Maxime Ripard
2016-01-31 1:20 ` [PATCH 03/14] clk: sunxi: add bus " Vishnu Patekar
2016-02-01 15:03 ` Rob Herring
2016-02-01 15:13 ` Chen-Yu Tsai
2016-02-02 13:13 ` Maxime Ripard [this message]
2016-01-31 1:20 ` [PATCH 04/14] clk: sunxi: add ahb1 clock " Vishnu Patekar
2016-02-01 14:49 ` Rob Herring
2016-02-01 14:54 ` Chen-Yu Tsai
2016-02-02 13:17 ` Maxime Ripard
2016-02-04 6:06 ` Vishnu Patekar
2016-02-04 8:01 ` Maxime Ripard
2016-02-12 5:24 ` Vishnu Patekar
2016-01-31 1:20 ` [PATCH 05/14] clk: sunxi: Add APB1 " Vishnu Patekar
2016-02-01 14:50 ` Rob Herring
2016-01-31 1:20 ` [PATCH 06/14] ARM: dts: sun8i-a83t: Correct low speed oscillator clocks Vishnu Patekar
2016-02-02 13:18 ` Maxime Ripard
2016-02-02 13:19 ` Maxime Ripard
2016-02-04 8:51 ` Vishnu Patekar
2016-02-04 12:04 ` Maxime Ripard
2016-01-31 1:20 ` [PATCH 07/14] ARM: dts: sun8i-a83t: Add basic clocks and resets Vishnu Patekar
2016-01-31 1:21 ` [PATCH 08/14] ARM: dts: sun8i-a83t: add mmc clock nodes Vishnu Patekar
2016-01-31 1:21 ` [PATCH 09/14] ARM: dts: sun8i-a83t: Add mmc controller nodes Vishnu Patekar
2016-01-31 1:21 ` [PATCH 10/14] ARM: dts: sun8i-a83t: Add PRCM related clocks and resets Vishnu Patekar
[not found] ` <CAGb2v67iO-816KaLttWRRPL2f7hpfgJ1--p69tD_oOrewmOjCA@mail.gmail.com>
2016-02-12 16:06 ` Vishnu Patekar
2016-01-31 1:21 ` [PATCH 11/14] ARM: dts: sun8i-a83t: Add R_PIO controller node to the dtsi Vishnu Patekar
2016-01-31 1:21 ` [PATCH 12/14] ARM: dts: sun8i-a83t: Add RSB nodes to dtsi Vishnu Patekar
2016-01-31 1:21 ` [PATCH 13/14] ARM: dts: sun8i: enable mmc for H8Homlet Board Vishnu Patekar
2016-01-31 1:21 ` [PATCH 14/14] ARM: dts: sun8i: Add A83T based Sinovoip Bpi-M3 Board Vishnu Patekar
[not found] ` <CAGb2v65BwAcT8920WXt7dBjNx4zjycw2Ea+sNZrm0aM_3JA8pA@mail.gmail.com>
2016-02-04 4:25 ` Vishnu Patekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160202131347.GP4652@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=emilio@elopez.com.ar \
--cc=galak@codeaurora.org \
--cc=hdegoede@redhat.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jenskuske@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=patchesrdh@mveas.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=vishnupatekar0510@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).