From: Stephen Boyd <sboyd@codeaurora.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Michael Turquette <mturquette@baylibre.com>, linux-clk@vger.kernel.org
Subject: Re: [PATCH] clk: versatile: mask VCO bits before writing
Date: Wed, 10 Feb 2016 09:56:57 -0800 [thread overview]
Message-ID: <20160210175657.GF30978@codeaurora.org> (raw)
In-Reply-To: <CACRpkdafovzA6Ci31aX09nue77G3N2AomPoMbAT-gOTUYxtKHQ@mail.gmail.com>
On 02/10, Linus Walleij wrote:
> On Wed, Feb 3, 2016 at 2:47 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
>
> > The Versatile syscon ICST driver OR:s the bits into place but
> > forgets to mask the previous value, making the code only work
> > if the register is zero or giving haphazard results. Mask the
> > 19 bits used by the Versatile syscon interface register.
> >
> > Regression caused and now fixed by yours truly.
> >
> > Cc: Michael Turquette <mturquette@baylibre.com>
> > Cc: Stephen Boyd <sboyd@codeaurora.org>
> > Cc: linux-clk@vger.kernel.org
> > Fixes: 179c8fb3c2a6 ("clk: versatile-icst: convert to use regmap")
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>
> Mike/Stephen, are you picking this for fixes?
>
Thanks, I missed this one. Applied to clk-fixes.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
prev parent reply other threads:[~2016-02-10 17:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 13:47 [PATCH] clk: versatile: mask VCO bits before writing Linus Walleij
2016-02-10 8:23 ` Linus Walleij
2016-02-10 17:56 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160210175657.GF30978@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linus.walleij@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox