public inbox for linux-clk@vger.kernel.org
 help / color / mirror / Atom feed
From: Michael Turquette <mturquette@baylibre.com>
To: Antony Pavlov <antonynpavlov@gmail.com>,  linux-mips@linux-mips.org
Cc: "Marek Vasut" <marex@denx.de>, "Wills Wang" <wills.wang@live.com>,
	"Daniel Schwierzeck" <daniel.schwierzeck@gmail.com>,
	"Alban Bedel" <albeu@free.fr>,
	"Stephen Boyd" <sboyd@codeaurora.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Paul Burton" <paul.burton@imgtec.com>,
	linux-clk@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [RFC v5 01/15] WIP: clk: add Atheros AR933X SoCs clock driver
Date: Thu, 11 Feb 2016 18:21:24 -0800	[thread overview]
Message-ID: <20160212022124.3210.30707@quark.deferred.io> (raw)
In-Reply-To: <1455005641-7079-2-git-send-email-antonynpavlov@gmail.com>

Quoting Antony Pavlov (2016-02-09 00:13:47)
> +static void __init ar9130_init(struct device_node *np)
> +{
> +       int retval;
> +       struct ath79_cblk *cblk;
> +
> +       cblk =3D ath79_cblk_new(ar9331_clocks, ARRAY_SIZE(ar9331_clocks),=
 np);
> +       if (!cblk) {
> +               pr_err("%s: failed to initialise clk block\n", __func__);
> +               return;
> +       }
> +
> +       retval =3D ath79_cblk_register_clocks(cblk);
> +       if (retval)
> +               pr_err("%s: failed to register clocks\n", __func__);
> +}
> +CLK_OF_DECLARE(ar933x_clk, "qca,ar9330-pll", ar9130_init);

Is there any reason this isn't a platform_driver?

Thanks,
Mike

      parent reply	other threads:[~2016-02-12  2:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1455005641-7079-1-git-send-email-antonynpavlov@gmail.com>
2016-02-09  8:13 ` [RFC v5 01/15] WIP: clk: add Atheros AR933X SoCs clock driver Antony Pavlov
2016-02-09 11:05   ` Marek Vasut
2016-02-09 21:51   ` Alban
2016-02-11 12:50     ` Antony Pavlov
2016-02-12  2:21   ` Michael Turquette [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160212022124.3210.30707@quark.deferred.io \
    --to=mturquette@baylibre.com \
    --cc=albeu@free.fr \
    --cc=antonynpavlov@gmail.com \
    --cc=daniel.schwierzeck@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=marex@denx.de \
    --cc=paul.burton@imgtec.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@codeaurora.org \
    --cc=wills.wang@live.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox