From: Michael Turquette <mturquette@baylibre.com>
To: Stephen Boyd <sboyd@codeaurora.org>,
Cc: linux-clk@vger.kernel.org, lee.jones@linaro.org,
maxime.ripard@free-electrons.com, maxime.coquelin@st.com,
geert@linux-m68k.org, heiko@sntech.de, andre.przywara@arm.com,
rklein@nvidia.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v42 3/6] clk: Provide OF helper to mark clocks as CRITICAL
Date: Mon, 15 Feb 2016 12:09:53 -0800 [thread overview]
Message-ID: <20160215200953.2278.7427@quark.deferred.io> (raw)
In-Reply-To: <20160213010941.GH4847@codeaurora.org>
Quoting Stephen Boyd (2016-02-12 17:09:41)
> On 02/11, Michael Turquette wrote:
> > +int of_clk_mark_if_critical(struct device_node *np,
> > + int index, unsigned long *flags)
> > +{
> > + struct property *prop;
> > + const __be32 *cur;
> > + uint32_t idx;
> > +
> > + if (!np || !flags)
> > + return -EINVAL;
> > +
> > + of_property_for_each_u32(np, "clock-critical", prop, cur, idx)
> > + if (index =3D=3D idx)
> > + *flags |=3D CLK_IS_CRITICAL;
> > +
> > + return 0;
> > +}
> =
> I hope we don't have to export this to modules...
I hope so too.
If a clock provider driver is able to build as a module AND has a
corresponding device tree node, then likely they won't need this thing.
This is more for the CLK_OF_DECLARE crowd (flexgen, allwinner, etc).
Regards,
Mike
> =
> -- =
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-02-15 20:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 21:19 [PATCH v42 0/6] critical clocks and handoff clocks Michael Turquette
2016-02-11 21:19 ` [PATCH v42 1/6] clk: Allow clocks to be marked as CRITICAL Michael Turquette
2016-02-12 8:03 ` Lee Jones
2016-02-13 1:14 ` Stephen Boyd
2016-02-15 20:27 ` Michael Turquette
2016-02-19 2:03 ` Stephen Boyd
2016-02-19 17:30 ` Michael Turquette
2016-02-11 21:19 ` [PATCH v42 2/6] clk: WARN_ON about to disable a critical clock Michael Turquette
2016-02-13 1:14 ` Stephen Boyd
2016-02-11 21:19 ` [PATCH v42 3/6] clk: Provide OF helper to mark clocks as CRITICAL Michael Turquette
2016-02-12 8:02 ` Lee Jones
2016-03-30 17:15 ` Michael Turquette
2016-03-31 9:14 ` Lee Jones
2016-02-13 1:09 ` Stephen Boyd
2016-02-15 20:09 ` Michael Turquette [this message]
2016-02-11 21:19 ` [PATCH v42 4/6] clk: per-user clk prepare & enable ref counts Michael Turquette
2016-02-13 1:16 ` Stephen Boyd
2016-02-11 21:19 ` [PATCH v42 5/6] clk: clk_put WARNs if user has not disabled clk Michael Turquette
2016-02-13 1:18 ` Stephen Boyd
2016-02-14 14:51 ` Geert Uytterhoeven
2016-02-11 21:19 ` [PATCH v42 6/6] clk: introduce CLK_ENABLE_HAND_OFF flag Michael Turquette
2016-02-12 8:06 ` [PATCH v42 0/6] critical clocks and handoff clocks Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160215200953.2278.7427@quark.deferred.io \
--to=mturquette@baylibre.com \
--cc=andre.przywara@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=heiko@sntech.de \
--cc=lee.jones@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.coquelin@st.com \
--cc=maxime.ripard@free-electrons.com \
--cc=rklein@nvidia.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).