Linux clock framework development
 help / color / mirror / Atom feed
From: Michael Turquette <mturquette@baylibre.com>
To: Akinobu Mita <akinobu.mita@gmail.com>,  linux-clk@vger.kernel.org
Cc: "Akinobu Mita" <akinobu.mita@gmail.com>,
	"Stephen Boyd" <sboyd@codeaurora.org>
Subject: Re: [PATCH] clk: add userspace clock consumer
Date: Wed, 17 Feb 2016 13:14:35 -0800	[thread overview]
Message-ID: <20160217211435.2278.78093@quark.deferred.io> (raw)
In-Reply-To: <1455547251-4944-1-git-send-email-akinobu.mita@gmail.com>

Quoting Akinobu Mita (2016-02-15 06:40:51)
> +static ssize_t clk_show_state(struct device *dev, struct device_attribut=
e *attr,
> +                       char *buf)
> +{
> +       struct clk_userspace_consumer *consumer =3D dev_get_drvdata(dev);
> +
> +       if (consumer->enabled)
> +               return sprintf(buf, "enabled\n");
> +
> +       return sprintf(buf, "disabled\n");
> +}
> +
> +static ssize_t clk_store_state(struct device *dev,

s/state/enable/

...
> +static const struct of_device_id userspace_consumer_id[] =3D {
> +       { .compatible =3D "linux,clk-userspace-consumer" },

Let's use "clock" instead of "clk" for the compat string, this is how
the other bindings do it. We tend to use "clk" when talking specifically
about Linux.

Regards,
Mike

  parent reply	other threads:[~2016-02-17 21:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-15 14:40 [PATCH] clk: add userspace clock consumer Akinobu Mita
2016-02-15 23:02 ` Michael Turquette
2016-02-17 13:18   ` Akinobu Mita
2016-02-17 21:24     ` Michael Turquette
2016-02-18 14:09       ` Akinobu Mita
2016-02-18 19:34         ` Michael Turquette
2016-02-17 21:14 ` Michael Turquette [this message]
2016-02-18 14:07   ` Akinobu Mita

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160217211435.2278.78093@quark.deferred.io \
    --to=mturquette@baylibre.com \
    --cc=akinobu.mita@gmail.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox