From: Michael Turquette <mturquette@baylibre.com>
To: Joachim Eastwood <manabian@gmail.com>, sboyd@codeaurora.org
Cc: "Joachim Eastwood" <manabian@gmail.com>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/2] clk: add lpc18xx creg clk driver
Date: Wed, 24 Feb 2016 13:05:53 -0800 [thread overview]
Message-ID: <20160224210553.2278.56679@quark.deferred.io> (raw)
In-Reply-To: <1455994417-4471-2-git-send-email-manabian@gmail.com>
Quoting Joachim Eastwood (2016-02-20 10:53:36)
> +static const struct clk_ops clk_creg_32k =3D {
> + .enable =3D clk_creg_enable,
> + .disable =3D clk_creg_disable,
There should be a .is_enabled here.
> + .prepare =3D clk_creg_32k_prepare,
> + .unprepare =3D clk_creg_32k_unprepare,
> + .is_prepared =3D clk_creg_32k_is_prepared,
> +};
> +
> +static const struct clk_ops clk_creg_1k =3D {
> + .enable =3D clk_creg_enable,
> + .disable =3D clk_creg_disable,
Ditto.
Otherwise patch looks good to me. Thanks a lot for all of the rework.
Regards,
Mike
next prev parent reply other threads:[~2016-02-24 21:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-20 18:53 [PATCH v2 0/2] CREG clk driver for NXP LPC18xx family Joachim Eastwood
2016-02-20 18:53 ` [PATCH v2 1/2] clk: add lpc18xx creg clk driver Joachim Eastwood
2016-02-22 21:55 ` Stephen Boyd
2016-02-24 21:05 ` Michael Turquette [this message]
2016-02-20 18:53 ` [PATCH v2 2/2] doc: dt: add documentation for lpc1850-creg-clk driver Joachim Eastwood
2016-02-23 18:08 ` Rob Herring
2016-02-23 18:53 ` Joachim Eastwood
2016-02-23 21:58 ` Rob Herring
2016-02-23 22:12 ` Joachim Eastwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160224210553.2278.56679@quark.deferred.io \
--to=mturquette@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=manabian@gmail.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox