From: Michael Turquette <mturquette@baylibre.com>
To: Joachim Eastwood <manabian@gmail.com>, sboyd@codeaurora.org
Cc: "Joachim Eastwood" <manabian@gmail.com>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 1/2] clk: add lpc18xx creg clk driver
Date: Wed, 02 Mar 2016 15:01:59 -0800 [thread overview]
Message-ID: <20160302230159.12762.59247@quark.deferred.io> (raw)
In-Reply-To: <1456351460-15483-2-git-send-email-manabian@gmail.com>
Hi Joachim,
Quoting Joachim Eastwood (2016-02-24 14:04:19)
> +static struct clk *clk_register_creg_clk(struct clk_creg_data *creg_clk,
> + const char **parent_name,
> + struct regmap *syscon)
> +{
> + struct clk_init_data init;
> +
> + init.ops =3D creg_clk->ops;
> + init.name =3D creg_clk->name;
> + init.parent_names =3D parent_name;
> + init.num_parents =3D 1;
> +
> + creg_clk->reg =3D syscon;
> + creg_clk->hw.init =3D &init;
> +
> + return clk_register(NULL, &creg_clk->hw);
This should be devm_clk_register with your struct device *dev passed
into it.
Otherwise this patch looks good for merge.
Regards,
Mike
next prev parent reply other threads:[~2016-03-02 23:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-24 22:04 [PATCH v4 0/2] CREG clk driver for NXP LPC18xx family Joachim Eastwood
2016-02-24 22:04 ` [PATCH v4 1/2] clk: add lpc18xx creg clk driver Joachim Eastwood
2016-03-02 23:01 ` Michael Turquette [this message]
2016-03-02 23:27 ` Joachim Eastwood
2016-03-03 20:13 ` Stephen Boyd
2016-02-24 22:04 ` [PATCH v4 2/2] doc: dt: add documentation for lpc1850-creg-clk driver Joachim Eastwood
2016-03-02 17:31 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160302230159.12762.59247@quark.deferred.io \
--to=mturquette@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=manabian@gmail.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox