From: Stephen Boyd <sboyd@codeaurora.org>
To: Jose Abreu <Jose.Abreu@synopsys.com>
Cc: mturquette@baylibre.com, Vineet.Gupta1@synopsys.com,
linux-snps-arc@lists.infradead.org, Alexey.Brodkin@synopsys.com,
linux-clk@vger.kernel.org
Subject: Re: [PATCH v3] clk/axs10x: Add I2S PLL clock driver
Date: Fri, 15 Apr 2016 17:35:09 -0700 [thread overview]
Message-ID: <20160416003509.GM26353@codeaurora.org> (raw)
In-Reply-To: <57027A79.8060708@synopsys.com>
On 04/04, Jose Abreu wrote:
> >> + fbdiv = i2s_pll_get_value(readl((void *)PLL_FBDIV_ADDR));
> >> + odiv = i2s_pll_get_value(readl((void *)PLL_ODIV0_ADDR));
> >> +
> >> + return (((clk->ref_clk / idiv ) * fbdiv) / odiv);
> > Again, too many parentheses. Also, any concerns of 32-bit
> > truncation here (i.e. is 64-bit math needed)?
>
> You are right there is no need to use 64-bit math, will change in next version.
Well it wasn't 64-bit math in the first place, so the question
was more if you wanted to use 64-bit math.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-04-16 0:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 17:08 [PATCH v3] clk/axs10x: Add I2S PLL clock driver Jose Abreu
2016-04-02 1:02 ` Stephen Boyd
2016-04-04 14:30 ` Jose Abreu
2016-04-16 0:35 ` Stephen Boyd [this message]
2016-04-04 11:04 ` Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160416003509.GM26353@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=Alexey.Brodkin@synopsys.com \
--cc=Jose.Abreu@synopsys.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).