From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f50.google.com ([74.125.82.50]:37654 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750954AbcEKHiq (ORCPT ); Wed, 11 May 2016 03:38:46 -0400 Received: by mail-wm0-f50.google.com with SMTP id a17so66351030wme.0 for ; Wed, 11 May 2016 00:38:45 -0700 (PDT) Date: Wed, 11 May 2016 08:38:55 +0100 From: Lee Jones To: Masahiro Yamada Cc: linux-arm-kernel , Arnd Bergmann , Mauro Carvalho Chehab , Greg Kroah-Hartman , Linux Kernel Mailing List , "David S. Miller" , Guenter Roeck , Philipp Zabel , Jiri Slaby , Andrew Morton , linux-clk@vger.kernel.org, Kalle Valo Subject: Re: [RFC PATCH 01/21] mfd: uniphier: add UniPhier MFD driver Message-ID: <20160511073855.GQ19473@dell> References: <1462873862-30940-1-git-send-email-yamada.masahiro@socionext.com> <1462873862-30940-2-git-send-email-yamada.masahiro@socionext.com> <20160510112622.GL19473@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: Sender: linux-clk-owner@vger.kernel.org List-ID: On Wed, 11 May 2016, Masahiro Yamada wrote: > Hi Lee, > > 2016-05-10 20:26 GMT+09:00 Lee Jones : > >> +}; > >> +MODULE_DEVICE_TABLE(of, uniphier_mfd_match); > > > > NACK. Please do not mix MFD and DT registration. > > OK, thanks for review. > > > My basic thought was: > > - Add an MFD node to my DTS only once. > If I need to expand it in the future, I will just > need to modify drivers/mtd/uniphier-mfd.c. > It is just kernel-internal modification, so it does not > bother DT binding at all. > > - Simplify the node topology of DTS. Just describe the hardware in DT. If you do so accurately, there should be no requirement to change it (in theory). -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog