From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 7 Jun 2016 18:41:39 +0200 From: Boris Brezillon To: Ben Dooks Cc: linux-kernel@lists.codethink.co.uk, Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] clk: at91: make of_sama5d2_clk_generated_setup() static Message-ID: <20160607184139.69411eef@bbrezillon> In-Reply-To: <1465317489-14920-1-git-send-email-ben.dooks@codethink.co.uk> References: <1465317489-14920-1-git-send-email-ben.dooks@codethink.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII List-ID: On Tue, 7 Jun 2016 17:38:09 +0100 Ben Dooks wrote: > The of_sama5d2_clk_generated_setup() is not exported outside > of the driver, so make it static to fix the warning about it > being not static: > > drivers/clk/at91/clk-generated.c:270:13: warning: symbol 'of_sama5d2_clk_generated_setup' was not declared. Should it be static? > > Signed-off-by: Ben Dooks Acked-by: Boris Brezillon > --- > Cc: Boris Brezillon > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: linux-clk@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > --- > drivers/clk/at91/clk-generated.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/at91/clk-generated.c b/drivers/clk/at91/clk-generated.c > index e1aa210..7f6bec8 100644 > --- a/drivers/clk/at91/clk-generated.c > +++ b/drivers/clk/at91/clk-generated.c > @@ -267,7 +267,7 @@ at91_clk_register_generated(struct regmap *regmap, spinlock_t *lock, const char > return clk; > } > > -void __init of_sama5d2_clk_generated_setup(struct device_node *np) > +static void __init of_sama5d2_clk_generated_setup(struct device_node *np) > { > int num; > u32 id; -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com