From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Date: Sun, 12 Jun 2016 20:24:25 +0800 From: Dong Aisheng To: Thomas Gleixner Cc: Shawn Guo , Lucas Stach , Michael Turquette , Stephen Boyd , "linux-kernel@vger.kernel.org" , Stefan Agner , mingo@redhat.com, "kernel@pengutronix.de" , linux-clk@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH 1/2] clk: imx: do not sleep if IRQ's are still disabled Message-ID: <20160612122425.GG32690@shlinux2> References: <1461663072.7839.17.camel@pengutronix.de> <20160427015835.GE30692@tiger> <20160602145915.GA31124@shlinux2> <20160607070440.GA32573@shlinux2> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: List-ID: On Thu, Jun 09, 2016 at 10:08:01PM +0200, Thomas Gleixner wrote: > On Tue, 7 Jun 2016, Dong Aisheng wrote: > > Then it may need introduce a lot changes and increase many new core APIs. > > Is that a problem? > > No. That's all better than each driver having broken workarounds. It's a > common problem so it wants to be addressed at the core level. There you have a > central point to do this and you can still catch abusers which call stuff from > the wrong context. The hacks in the drivers don't allow that because they look > at the context, i.e. irq disabled, instead of checking the system state. > Okay, thanks. If you wouldn't mind i could send out a patch based on your suggestion for further discussion. Thanks Regards Dong Aisheng > Thanks, > > tglx