linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Turquette <mturquette@baylibre.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
	daniel.lezcano@linaro.org, tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org,
	"Russell King" <linux@arm.linux.org.uk>,
	"open list:CLK API" <linux-clk@vger.kernel.org>
Subject: Re: [PATCH 1/6] clk: Add missing clk_get_sys() stub
Date: Mon, 20 Jun 2016 14:18:49 -0700	[thread overview]
Message-ID: <20160620211849.24587.73336@quark.deferred.io> (raw)
In-Reply-To: <1464903697-3802-1-git-send-email-daniel.lezcano@linaro.org>

Hi Daniel,

Quoting Daniel Lezcano (2016-06-02 14:41:32)
> When compiling with the COMPILE_TEST option set, the clps711x does not
> compile because of the clk_get_sys() noop stub missing.
> =

> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>

This looks OK to me. Russell maintains clkdev and the clk.h stuff, so it
would be good to get his ack. Please feel free to add:

Reviewed-by: Michael Turquette <mturquette@baylibre.com>

Regards,
Mike

> ---
>  include/linux/clk.h | 4 ++++
>  1 file changed, 4 insertions(+)
> =

> diff --git a/include/linux/clk.h b/include/linux/clk.h
> index 0df4a51..834179f 100644
> --- a/include/linux/clk.h
> +++ b/include/linux/clk.h
> @@ -461,6 +461,10 @@ static inline struct clk *clk_get_parent(struct clk =
*clk)
>         return NULL;
>  }
>  =

> +static inline struct clk *clk_get_sys(const char *dev_id, const char *co=
n_id)
> +{
> +       return NULL;
> +}
>  #endif
>  =

>  /* clk_prepare_enable helps cases using clk_enable in non-atomic context=
. */
> -- =

> 1.9.1
>=20

      parent reply	other threads:[~2016-06-20 21:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-02 21:41 [PATCH 1/6] clk: Add missing clk_get_sys() stub Daniel Lezcano
2016-06-06  7:19 ` Daniel Lezcano
2016-06-13  8:18 ` Daniel Lezcano
2016-06-20 21:18 ` Michael Turquette [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160620211849.24587.73336@quark.deferred.io \
    --to=mturquette@baylibre.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).