Re: [PATCH v3 4/8] rtc: ac100: Add RTC driver for X-Powers AC100

Alexandre Belloni
2016-06-26T01:02:00Z

On 20/06/2016 at 10:52:14 +0800, Chen-Yu Tsai wrote :
> +static int ac100_rtc_probe(struct platform_device *pdev)
> +{
> + struct ac100_dev *ac100 = dev_get_drvdata(pdev->dev.parent);
> + struct ac100_rtc_dev *chip;
> + int ret;
> +
> + chip = devm_kzalloc(&pdev->dev, sizeof(*chip), GFP_KERNEL);
> + platform_set_drvdata(pdev, chip);
> + chip->dev = &pdev->dev;
> + chip->regmap = ac100->regmap;
> + mutex_init(&chip->mutex);
> +
> + chip->irq = of_irq_get(pdev->dev.of_node, 0);

Forgot that one, platform_get_irq() is probably more common but I don't
care that much. I think you can then avoid including of.h and of_irq.h.

> + if (chip->irq < 0) {
> + dev_err(&pdev->dev, "No IRQ resource\n");
> + return chip->irq;
> + }
> +

--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering