From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 28 Jun 2016 10:13:18 -0700 From: Stephen Boyd To: Geert Uytterhoeven Cc: Geert Uytterhoeven , Michael Turquette , Simon Horman , Magnus Damm , "open list:MEDIA DRIVERS FOR RENESAS - FCP" , linux-clk , Joe Perches Subject: Re: [git pull] clk: renesas: Add support for R-Car M3-W Message-ID: <20160628171318.GX1521@codeaurora.org> References: <1465212804-21391-1-git-send-email-geert+renesas@glider.be> <20160621005112.GM1521@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: List-ID: On 06/21, Geert Uytterhoeven wrote: > Hi Stephen, > > On Tue, Jun 21, 2016 at 2:51 AM, Stephen Boyd wrote: > > On 06/06, Geert Uytterhoeven wrote: > >> Hi Mike, Stephen, > >> > >> The following changes since commit 1a695a905c18548062509178b98bc91e67510864: > >> > >> Linux 4.7-rc1 (2016-05-29 09:29:24 -0700) > >> > >> are available in the git repository at: > >> > >> git://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git tags/clk-renesas-for-v4.8-tag1 > >> > >> for you to fetch changes up to e4e2d7c388350eba8b1dbc2569441ac9b545a8c4: > >> > >> clk: renesas: cpg-mssr: Add support for R-Car M3-W (2016-06-06 11:58:35 +0200) > >> > > > > Checkpatch complains... > > > > ERROR: Use of const init definition must use __initconst > > #712: FILE: drivers/clk/renesas/rcar-gen3-cpg.c:248: > > +static const struct rcar_gen3_cpg_pll_config *cpg_pll_config __initdata; > > > > Seems like a valid problem. Any chance it can be fixed? > > It is a false positive: the data pointed to is const, the pointer > variable isn't. > Argh thanks. It would be nice if sparse complained about that instead of checkpatch so that we got a better parse on the actual type that is marked initdata. Anyway, I see this pull is superseded now. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project