linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [bug report] clk: ls1x: Update relationship among all clocks
@ 2016-07-13 15:51 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2016-07-13 15:51 UTC (permalink / raw)
  To: keguang.zhang; +Cc: linux-clk

Hello Kelvin Cheung,

The patch 3526f74fa925: "clk: ls1x: Update relationship among all
clocks" from Oct 10, 2014, leads to the following static checker
warning:

	drivers/clk/clk-ls1x.c:38 ls1x_pll_recalc_rate()
	warn: mask and shift to zero

drivers/clk/clk-ls1x.c
    32  static unsigned long ls1x_pll_recalc_rate(struct clk_hw *hw,
    33                                            unsigned long parent_rate)
    34  {
    35          u32 pll, rate;
    36  
    37          pll = __raw_readl(LS1X_CLK_PLL_FREQ);
    38          rate = 12 + (pll & 0x3f) + (((pll >> 8) & 0x3ff) >> 10);

0x3ff >> 10 is zero.  It's not clear to me what is intended.

    39          rate *= OSC;
    40          rate >>= 1;
    41  
    42          return rate;
    43  }

regards,
dan carpenter

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-07-13 15:52 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-13 15:51 [bug report] clk: ls1x: Update relationship among all clocks Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).