* [PATCH] clk: qoriq: fix a register offset error
@ 2016-08-15 7:28 yuantian.tang
2016-08-15 16:32 ` Scott Wood
2016-08-18 23:51 ` Stephen Boyd
0 siblings, 2 replies; 3+ messages in thread
From: yuantian.tang @ 2016-08-15 7:28 UTC (permalink / raw)
To: mturquette
Cc: linux-clk, linux-kernel, scott.wood, Tang Yuantian, Tang Yuantian
From: Tang Yuantian <Yuantian.Tang@nxp.com>
The offset of Core Cluster clock control/status register
on cluster group V3 version is different from others, and
should be plus 0x70000.
Signed-off-by: Tang Yuantian <yuantian.tang@nxp.com>
---
drivers/clk/clk-qoriq.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c
index f4c455a..05e416c 100644
--- a/drivers/clk/clk-qoriq.c
+++ b/drivers/clk/clk-qoriq.c
@@ -774,7 +774,11 @@ static struct clk * __init create_one_cmux(struct clockgen *cg, int idx)
if (!hwc)
return NULL;
- hwc->reg = cg->regs + 0x20 * idx;
+ if (cg->info.flags & CG_VER3)
+ hwc->reg = cg->regs + 0x70000 + 0x20 * idx;
+ else
+ hwc->reg = cg->regs + 0x20 * idx;
+
hwc->info = cg->info.cmux_groups[cg->info.cmux_to_group[idx]];
/*
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: qoriq: fix a register offset error
2016-08-15 7:28 [PATCH] clk: qoriq: fix a register offset error yuantian.tang
@ 2016-08-15 16:32 ` Scott Wood
2016-08-18 23:51 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Scott Wood @ 2016-08-15 16:32 UTC (permalink / raw)
To: yuantian.tang, mturquette; +Cc: linux-clk, linux-kernel, scott.wood
On Mon, 2016-08-15 at 15:28 +0800, yuantian.tang@nxp.com wrote:
> From: Tang Yuantian <Yuantian.Tang@nxp.com>
>
> The offset of Core Cluster clock control/status register
> on cluster group V3 version is different from others, and
> should be plus 0x70000.
>
> Signed-off-by: Tang Yuantian <yuantian.tang@nxp.com>
> ---
> drivers/clk/clk-qoriq.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c
> index f4c455a..05e416c 100644
> --- a/drivers/clk/clk-qoriq.c
> +++ b/drivers/clk/clk-qoriq.c
> @@ -774,7 +774,11 @@ static struct clk * __init create_one_cmux(struct
> clockgen *cg, int idx)
> if (!hwc)
> return NULL;
>
> - hwc->reg = cg->regs + 0x20 * idx;
> + if (cg->info.flags & CG_VER3)
> + hwc->reg = cg->regs + 0x70000 + 0x20 * idx;
> + else
> + hwc->reg = cg->regs + 0x20 * idx;
> +
> hwc->info = cg->info.cmux_groups[cg->info.cmux_to_group[idx]];
Reviewed-by: Scott Wood <oss@buserror.net>
-Scott
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: qoriq: fix a register offset error
2016-08-15 7:28 [PATCH] clk: qoriq: fix a register offset error yuantian.tang
2016-08-15 16:32 ` Scott Wood
@ 2016-08-18 23:51 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2016-08-18 23:51 UTC (permalink / raw)
To: yuantian.tang; +Cc: mturquette, linux-clk, linux-kernel, scott.wood
On 08/15, yuantian.tang@nxp.com wrote:
> From: Tang Yuantian <Yuantian.Tang@nxp.com>
>
> The offset of Core Cluster clock control/status register
> on cluster group V3 version is different from others, and
> should be plus 0x70000.
>
> Signed-off-by: Tang Yuantian <yuantian.tang@nxp.com>
> ---
Applied to clk-next
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-18 23:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-15 7:28 [PATCH] clk: qoriq: fix a register offset error yuantian.tang
2016-08-15 16:32 ` Scott Wood
2016-08-18 23:51 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).