From: Stephen Boyd <sboyd@codeaurora.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
linux-clk@vger.kernel.org, Russell King <linux@armlinux.org.uk>
Subject: Re: [PATCH 3/3 v2] clk: versatile/icst: support for AP baseboard clocks
Date: Thu, 25 Aug 2016 13:06:32 -0700 [thread overview]
Message-ID: <20160825200632.GQ19826@codeaurora.org> (raw)
In-Reply-To: <1471857574-13125-3-git-send-email-linus.walleij@linaro.org>
On 08/22, Linus Walleij wrote:
> @@ -143,6 +180,17 @@ static int vco_set(struct clk_icst *icst, struct icst_vco vco)
> if (vco.r != 22)
> pr_err("ICST error: tried to use RDW != 22\n");
> break;
> + case ICST_INTEGRATOR_AP_SYS:
> + mask = INTEGRATOR_AP_SYS_BITS;
> + val &= ~0xFF; /* Uses 8 bits */
drivers/clk/versatile/clk-icst.c: In function ‘icst_set_rate’:
drivers/clk/versatile/clk-icst.c:185:7: warning: ‘val’ may be used uninitialized in this function [-Wuninitialized]
> + val |= vco.v & 0xFF;
> + if (vco.v & 0x100)
> + pr_err("ICST error: tried to set bit 8 of VDW\n");
> + if (vco.s != 3)
> + pr_err("ICST error: tried to use VOD != 1\n");
> + if (vco.r != 46)
> + pr_err("ICST error: tried to use RDW != 22\n");
> + break;
> case ICST_INTEGRATOR_CP_CM_CORE:
> mask = INTEGRATOR_CP_CM_CORE_BITS; /* Uses 12 bits */
> val = (vco.v & 0xFF) | vco.s << 8;
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-08-25 20:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-22 9:19 [PATCH 1/3 v2] clk: versatile add DT bindings for the ICST CM variants Linus Walleij
2016-08-22 9:19 ` [PATCH 2/3 v2] clk: versatile/icst: add Integrator core module clocks Linus Walleij
2016-08-25 20:07 ` Stephen Boyd
2016-08-22 9:19 ` [PATCH 3/3 v2] clk: versatile/icst: support for AP baseboard clocks Linus Walleij
2016-08-25 20:06 ` Stephen Boyd [this message]
2016-08-27 12:02 ` Linus Walleij
2016-08-23 18:09 ` [PATCH 1/3 v2] clk: versatile add DT bindings for the ICST CM variants Rob Herring
2016-08-25 20:06 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160825200632.GQ19826@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linus.walleij@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox