Re: [PATCH v2 06/14] ARM: sun8i: clk: Add clk-factor rate application method

Ondřej Jirman
2016-07-01T06:34:21Z

[-- Attachment #1.1: Type: text/plain, Size: 867 bytes --]

On 1.7.2016 07:37, Jean-Francois Moine wrote:
> On Fri, 1 Jul 2016 02:50:57 +0200
> Ondřej Jirman <megous@megous.com> wrote:
>
>>> Since this is really specific, I guess you could simply make the
>>> clk_ops for the nkmp clocks public, and just re-implement set_rate
>>> using that logic.
>>
>> I would argue that this may be necessary for other PLL clocks too, if
>> you can get out of bounds output frequency, by changing the dividers too
>> early or too late. So perhaps this code should be generalized for other
>> PLL clocks too, instead.
>
> The documentation says that only the CPU and DDR PLLs can be dynamically
> changed after boot.

The question is what exactly is meant by after boot. :) Anyway, if the
kernel has no business changing some other PLLs, if there's code for
changing them, should it be dropped?

regards,
Ondrej

[-- Attachment #2: OpenPGP digital signature --]