From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
linux-clk@vger.kernel.org, tomasz.figa@gmail.com,
sboyd@codeaurora.org, mturquette@baylibre.com, kgene@kernel.org,
b.zolnierkie@samsung.com, linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 1/5] clk: samsung: exynos5410: Add clock IDs for PDMA and EPLL clocks
Date: Fri, 2 Sep 2016 19:36:08 +0200 [thread overview]
Message-ID: <20160902173608.GC9022@kozik-lap> (raw)
In-Reply-To: <74653ed5-827b-1ad6-e17a-0c8e173da29f@samsung.com>
On Fri, Sep 02, 2016 at 04:09:08PM +0200, Sylwester Nawrocki wrote:
> On 08/30/2016 11:54 AM, Krzysztof Kozlowski wrote:
> > On 08/22/2016 06:30 PM, Sylwester Nawrocki wrote:
> >> > The PDMA{0,1} and EPLL clock IDs are added separately in this
> >> > patch so the patch can be merged to the arm-soc tree as dependency.
> >> >
> >> > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> >> > ---
> >> > include/dt-bindings/clock/exynos5410.h | 3 +++
> >> > 1 file changed, 3 insertions(+)
> >> >
> >> > diff --git a/include/dt-bindings/clock/exynos5410.h b/include/dt-bindings/clock/exynos5410.h
> >> > index 85b467b..a74442a 100644
> >> > --- a/include/dt-bindings/clock/exynos5410.h
> >> > +++ b/include/dt-bindings/clock/exynos5410.h
> >> > @@ -19,6 +19,7 @@
> >> > #define CLK_FOUT_MPLL 4
> >> > #define CLK_FOUT_BPLL 5
> >> > #define CLK_FOUT_KPLL 6
> >> > +#define CLK_FOUT_EPLL 7
> >> >
> >> > /* gate for special clocks (sclk) */
> >> > #define CLK_SCLK_UART0 128
> >> > @@ -48,6 +49,8 @@
> >> > #define CLK_USI3 268
> >> > #define CLK_UART3 260
> >> > #define CLK_PWM 279
> >> > +#define CLK_PDMA0 280
> >> > +#define CLK_PDMA1 281
> >
> > How about making the IDs the same as in exynos5420? This way those
> > drivers could be merged someday in the future (if someone would be
> > bored...).
>
> OK, I will do it, but there is already mismatch in the PLL indices.
Oh, crap, I missed that difference. This means the drivers won't be
combined... so I am not sure whether keeping same IDs for rest brings
benefits. Whatever you chooses:
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2016-09-02 17:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-22 16:30 [PATCH 0/5] clk/samsung: Add support for PDMA, EPLL clocks on exynos5410 Sylwester Nawrocki
2016-08-22 16:30 ` [PATCH 1/5] clk: samsung: exynos5410: Add clock IDs for PDMA and EPLL clocks Sylwester Nawrocki
2016-08-30 9:54 ` Krzysztof Kozlowski
2016-09-02 14:09 ` Sylwester Nawrocki
2016-09-02 17:36 ` Krzysztof Kozlowski [this message]
2016-08-22 16:31 ` [PATCH 2/5] clk: samsung: exynos5410: Expose the peripheral DMA gate clocks Sylwester Nawrocki
2016-08-30 9:56 ` Krzysztof Kozlowski
2016-08-22 16:31 ` [PATCH 3/5] clk: samsung: Use common registration function for pll2550x Sylwester Nawrocki
2016-08-30 10:13 ` Krzysztof Kozlowski
2016-08-22 16:31 ` [PATCH 4/5] clk: samsung: Add support for EPLL on exynos5410 Sylwester Nawrocki
2016-08-30 10:36 ` Krzysztof Kozlowski
2016-09-02 15:15 ` Sylwester Nawrocki
2016-09-02 17:32 ` Krzysztof Kozlowski
2016-09-05 7:48 ` Sylwester Nawrocki
2016-08-22 16:31 ` [PATCH 5/5] clk: samsung: Add support for exynos5410 AUDSS clock controller Sylwester Nawrocki
2016-08-30 10:38 ` Krzysztof Kozlowski
2016-09-02 15:19 ` Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160902173608.GC9022@kozik-lap \
--to=krzk@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@codeaurora.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).