From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.codeaurora.org ([198.145.29.96]:59085 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751647AbcIHBS1 (ORCPT ); Wed, 7 Sep 2016 21:18:27 -0400 Date: Wed, 7 Sep 2016 18:18:25 -0700 From: Stephen Boyd To: Kevin Hilman Cc: Ulf Hansson , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, Xing Wu , Victor Wan , linux-amlogic@lists.infradead.org, Jerry Cao , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org Subject: Re: [PATCH v2 2/2] MMC: meson: initial support for GXBB platforms Message-ID: <20160908011825.GA19921@codeaurora.org> References: <20160803231843.23012-1-khilman@baylibre.com> <20160803231843.23012-2-khilman@baylibre.com> <20160823012124.GQ6502@codeaurora.org> <7hy433qpoo.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <7hy433qpoo.fsf@baylibre.com> Sender: linux-clk-owner@vger.kernel.org List-ID: On 09/07, Kevin Hilman wrote: > Stephen Boyd writes: > > On 08/03, Kevin Hilman wrote: > >> + host->mux.hw.init = &init; > >> + > >> + host->mux_clk = devm_clk_register(host->dev, &host->mux.hw); > > > > Hmm I was hoping to get rid of devm_clk_register() and replace it > > with devm_clk_hw_register() instead. All part of my grand plan to > > split providers from consumers, but this driver is different in > > the sense that it registers clks to provide to itself. Maybe we > > should make __clk_create_clk() into a real clk provider API so > > that we can use devm_clk_hw_register() here and then generate a > > clk for this device from the hw structure. > > So is there something else I should do here, or can we rework this later > after you rework the framework a bit? > That can wait for later. If nobody takes care of it I'll do it when I get around to it. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project