* [PATCH] clk: rk808: Pass the right pointer as the get_hw context
@ 2016-09-09 13:25 Tomeu Vizoso
2016-09-09 18:07 ` Stephen Boyd
0 siblings, 1 reply; 2+ messages in thread
From: Tomeu Vizoso @ 2016-09-09 13:25 UTC (permalink / raw)
To: linux-kernel; +Cc: Tomeu Vizoso, Michael Turquette, Stephen Boyd, linux-clk
Right now we are passing a pointer to a pointer to the structure that
will be used to fetch the clk hw, which gets casted later to a pointer
to the structure, thus getting garbage in the hw structs.
Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Fixes: a8b6e85db6a6 ("clk: rk808: Migrate to clk_hw based OF and
registration APIs")
---
drivers/clk/clk-rk808.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/clk-rk808.c b/drivers/clk/clk-rk808.c
index faa447e191ef..6461f2820a5b 100644
--- a/drivers/clk/clk-rk808.c
+++ b/drivers/clk/clk-rk808.c
@@ -138,7 +138,7 @@ static int rk808_clkout_probe(struct platform_device *pdev)
if (ret)
return ret;
- return of_clk_add_hw_provider(node, of_clk_rk808_get, &rk808_clkout);
+ return of_clk_add_hw_provider(node, of_clk_rk808_get, rk808_clkout);
}
static int rk808_clkout_remove(struct platform_device *pdev)
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] clk: rk808: Pass the right pointer as the get_hw context
2016-09-09 13:25 [PATCH] clk: rk808: Pass the right pointer as the get_hw context Tomeu Vizoso
@ 2016-09-09 18:07 ` Stephen Boyd
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Boyd @ 2016-09-09 18:07 UTC (permalink / raw)
To: Tomeu Vizoso; +Cc: linux-kernel, Michael Turquette, linux-clk
On 09/09, Tomeu Vizoso wrote:
> Right now we are passing a pointer to a pointer to the structure that
> will be used to fetch the clk hw, which gets casted later to a pointer
> to the structure, thus getting garbage in the hw structs.
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> Fixes: a8b6e85db6a6 ("clk: rk808: Migrate to clk_hw based OF and
> registration APIs")
> ---
Applied to clk-next
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-09 18:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-09 13:25 [PATCH] clk: rk808: Pass the right pointer as the get_hw context Tomeu Vizoso
2016-09-09 18:07 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).