From: Stephen Boyd <sboyd@codeaurora.org>
To: arvind.yadav.cs@gmail.com
Cc: mturquette@baylibre.com, a.hajda@samsung.com,
lee.jones@linaro.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: st: clk-flexgen: Unmap region obtained by of_iomap
Date: Wed, 14 Sep 2016 11:24:54 -0700 [thread overview]
Message-ID: <20160914182454.GR7243@codeaurora.org> (raw)
In-Reply-To: <57d92940.6329c80a.3d959.9d78@mx.google.com>
On 09/14, arvind.yadav.cs@gmail.com wrote:
> @@ -337,6 +339,8 @@ static void __init st_of_flexgen_setup(struct device_node *np)
> return;
>
> err:
> + if (reg)
This is always true? Why check?
> + iounmap(reg);
> if (clk_data)
> kfree(clk_data->clks);
> kfree(clk_data);
> --
> 1.7.9.5
>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-09-14 18:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 10:38 [PATCH] clk: st: clk-flexgen: Unmap region obtained by of_iomap arvind.yadav.cs
2016-09-14 18:24 ` Stephen Boyd [this message]
2016-09-19 17:44 ` arvind Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160914182454.GR7243@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=a.hajda@samsung.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).