* [PATCH] clk-kona-setup: Use kmalloc_array() in parent_process()
@ 2016-09-14 18:40 SF Markus Elfring
2016-09-14 18:45 ` Alex Elder
2016-09-14 20:47 ` Stephen Boyd
0 siblings, 2 replies; 3+ messages in thread
From: SF Markus Elfring @ 2016-09-14 18:40 UTC (permalink / raw)
To: bcm-kernel-feedback-list, linux-clk, Alex Elder, Florian Fainelli,
Matt Porter, Michael Turquette, Ray Jui, Scott Branden,
Stephen Boyd, Vaishali Thakkar
Cc: LKML, kernel-janitors, Julia Lawall
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 14 Sep 2016 20:26:05 +0200
A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus use the corresponding function "kmalloc_array".
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/clk/bcm/clk-kona-setup.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/bcm/clk-kona-setup.c b/drivers/clk/bcm/clk-kona-setup.c
index 526b0b0..a2e7e91 100644
--- a/drivers/clk/bcm/clk-kona-setup.c
+++ b/drivers/clk/bcm/clk-kona-setup.c
@@ -586,8 +586,9 @@ static u32 *parent_process(const char *clocks[],
}
/* There is at least one parent, so allocate a selector array */
-
- parent_sel = kmalloc(parent_count * sizeof(*parent_sel), GFP_KERNEL);
+ parent_sel = kmalloc_array(parent_count,
+ sizeof(*parent_sel),
+ GFP_KERNEL);
if (!parent_sel) {
pr_err("%s: error allocating %u parent selectors\n", __func__,
parent_count);
--
2.10.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] clk-kona-setup: Use kmalloc_array() in parent_process()
2016-09-14 18:40 [PATCH] clk-kona-setup: Use kmalloc_array() in parent_process() SF Markus Elfring
@ 2016-09-14 18:45 ` Alex Elder
2016-09-14 20:47 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Alex Elder @ 2016-09-14 18:45 UTC (permalink / raw)
To: SF Markus Elfring, bcm-kernel-feedback-list, linux-clk,
Florian Fainelli, Matt Porter, Michael Turquette, Ray Jui,
Scott Branden, Stephen Boyd, Vaishali Thakkar
Cc: LKML, kernel-janitors, Julia Lawall
On 09/14/2016 01:40 PM, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 14 Sep 2016 20:26:05 +0200
>
> A multiplication for the size determination of a memory allocation
> indicated that an array data structure should be processed.
> Thus use the corresponding function "kmalloc_array".
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Probably not needed in practice, but safer nevertheless.
Reviewed-by: Alex Elder <elder@linaro.org>
> ---
> drivers/clk/bcm/clk-kona-setup.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/bcm/clk-kona-setup.c b/drivers/clk/bcm/clk-kona-setup.c
> index 526b0b0..a2e7e91 100644
> --- a/drivers/clk/bcm/clk-kona-setup.c
> +++ b/drivers/clk/bcm/clk-kona-setup.c
> @@ -586,8 +586,9 @@ static u32 *parent_process(const char *clocks[],
> }
>
> /* There is at least one parent, so allocate a selector array */
> -
> - parent_sel = kmalloc(parent_count * sizeof(*parent_sel), GFP_KERNEL);
> + parent_sel = kmalloc_array(parent_count,
> + sizeof(*parent_sel),
> + GFP_KERNEL);
> if (!parent_sel) {
> pr_err("%s: error allocating %u parent selectors\n", __func__,
> parent_count);
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] clk-kona-setup: Use kmalloc_array() in parent_process()
2016-09-14 18:40 [PATCH] clk-kona-setup: Use kmalloc_array() in parent_process() SF Markus Elfring
2016-09-14 18:45 ` Alex Elder
@ 2016-09-14 20:47 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2016-09-14 20:47 UTC (permalink / raw)
To: SF Markus Elfring
Cc: bcm-kernel-feedback-list, linux-clk, Alex Elder, Florian Fainelli,
Matt Porter, Michael Turquette, Ray Jui, Scott Branden,
Vaishali Thakkar, LKML, kernel-janitors, Julia Lawall
On 09/14, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 14 Sep 2016 20:26:05 +0200
>
> A multiplication for the size determination of a memory allocation
> indicated that an array data structure should be processed.
> Thus use the corresponding function "kmalloc_array".
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
Applied to clk-next
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-14 20:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-14 18:40 [PATCH] clk-kona-setup: Use kmalloc_array() in parent_process() SF Markus Elfring
2016-09-14 18:45 ` Alex Elder
2016-09-14 20:47 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).