From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 17 Oct 2016 15:43:10 -0700 From: Stephen Boyd To: Shawn Guo Cc: Michael Turquette , John Stultz , Guodong Xu , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] clk: hi6220: use CLK_OF_DECLARE_DRIVER for sysctrl and mediactrl clock init Message-ID: <20161017224310.GM8871@codeaurora.org> References: <1475933892-16021-1-git-send-email-shawn.guo@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1475933892-16021-1-git-send-email-shawn.guo@linaro.org> List-ID: On 10/08, Shawn Guo wrote: > The hi6220-sysctrl and hi6220-mediactrl are not only clock provider but > also reset controller. It worked fine that single sysctrl/mediactrl > device node in DT can be used to initialize clock driver and populate > platform device for reset controller. But it stops working after > commit 989eafd0b609 ("clk: core: Avoid double initialization of clocks") > gets merged. The commit sets flag OF_POPULATED during clock > initialization to skip the platform device populating for the same > device node. On hi6220, it effectively makes hi6220-sysctrl reset > driver not probe any more. > > The patch changes hi6220 sysctrl and mediactrl clock init macro from > CLK_OF_DECLARE to CLK_OF_DECLARE_DRIVER, so that the reset driver using > the same hardware block can continue working. > > Signed-off-by: Shawn Guo > --- Applied to clk-fixes -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project