From: Stephen Boyd <sboyd@codeaurora.org>
To: Vladimir Zapolskiy <vz@mleia.com>
Cc: "Shawn Guo" <shawnguo@kernel.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Michael Turquette" <mturquette@baylibre.com>,
"Sascha Hauer" <kernel@pengutronix.de>,
"Fabio Estevam" <fabio.estevam@nxp.com>,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v2 3/4] clk: imx31: fix rewritten input argument of mx31_clocks_init()
Date: Tue, 25 Oct 2016 13:36:04 -0700 [thread overview]
Message-ID: <20161025203604.GB26139@codeaurora.org> (raw)
In-Reply-To: <1474848223-19728-4-git-send-email-vz@mleia.com>
On 09/26, Vladimir Zapolskiy wrote:
> Function mx31_clocks_init() is called during clock intialization on
> legacy boards with reference clock frequency passed as its input
> argument, this can be verified by examination of the function
> declaration found in arch/arm/mach-imx/common.h and actual function
> users which include that header file.
>
> Inside CCF driver the function ignores its input argument, by chance
> the used value in the function body is the same as input arguments on
> side of all callers.
>
> Fixes: d9388c843237 ("clk: imx31: Do not call mxc_timer_init twice when booting with DT")
> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
> ---
Acked-by: Stephen Boyd <sboyd@codeaurora.org>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-10-25 20:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-26 0:03 [PATCH v2 0/4] ARM: imx31: clock initialization fixes Vladimir Zapolskiy
2016-09-26 0:03 ` [PATCH v2 1/4] ARM: dts: imx31: fix clock control module interrupts description Vladimir Zapolskiy
2016-09-26 0:03 ` [PATCH v2 2/4] ARM: dts: imx31: move CCM device node to AIPS2 bus devices Vladimir Zapolskiy
2016-09-26 6:36 ` Uwe Kleine-König
2016-09-26 0:03 ` [PATCH v2 3/4] clk: imx31: fix rewritten input argument of mx31_clocks_init() Vladimir Zapolskiy
2016-09-26 6:23 ` Uwe Kleine-König
2016-10-25 20:36 ` Stephen Boyd [this message]
2016-09-26 0:03 ` [PATCH v2 4/4] ARM: clk: imx31: properly init clocks for machines with DT Vladimir Zapolskiy
2016-10-25 20:37 ` Stephen Boyd
2016-10-23 12:28 ` [PATCH v2 0/4] ARM: imx31: clock initialization fixes Shawn Guo
2016-10-25 20:37 ` Stephen Boyd
2016-11-01 8:50 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161025203604.GB26139@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=shawnguo@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).