From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 27 Oct 2016 17:27:02 -0700 From: Stephen Boyd To: Marek Szyprowski Cc: linux-clk@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Michael Turquette , Sylwester Nawrocki , Chanwoo Choi , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz , Javier Martinez Canillas Subject: Re: [PATCH v2] clk/samsung: Use CLK_OF_DECLARE_DRIVER initialization method for CLKOUT Message-ID: <20161028002702.GP26139@codeaurora.org> References: <1477462340-7867-1-git-send-email-m.szyprowski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1477462340-7867-1-git-send-email-m.szyprowski@samsung.com> List-ID: On 10/26, Marek Szyprowski wrote: > The Exynos PMU node is an interrupt, clock and PMU (Power Management Unit) > controller, and these functionalities are supported by different drivers > that matches the same compatible strings. > > Since commit 989eafd0b609 ("clk: core: Avoid double initialization of > clocks") the OF core flags clock controllers registered with the > CLK_OF_DECLARE() macro as OF_POPULATED, so platform devices with the same > compatible string will not be registered. > > This prevents the PMU platform device to be created, so the Exynos PMU > driver is never probed. This breaks (among other things) Suspend-to-RAM. > > Fix this by changing CLKOUT driver initialization method to > CLK_OF_DECLARE_DRIVER(), which doesn't clear the OF_POPULATED flag, so > later a platform device is created and the Exynos PMU platform driver > can be be probed properly. > > Fixes: 989eafd0b609 ("clk: core: Avoid double initialization of clocks") > Signed-off-by: Marek Szyprowski > --- Applied to clk-fixes -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project