* Re: [PATCH] driver core: Make Kconfig text for DEBUG_TEST_DRIVER_REMOVE stronger [not found] ` <1475856570-10743-1-git-send-email-labbott@redhat.com> @ 2016-10-31 10:12 ` Geert Uytterhoeven 2016-10-31 12:21 ` Greg Kroah-Hartman 0 siblings, 1 reply; 6+ messages in thread From: Geert Uytterhoeven @ 2016-10-31 10:12 UTC (permalink / raw) To: Laura Abbott Cc: Greg Kroah-Hartman, Rob Herring, Arnd Bergmann, linux-kernel@vger.kernel.org, linux-clk On Fri, Oct 7, 2016 at 6:09 PM, Laura Abbott <labbott@redhat.com> wrote: > The current state of driver removal is not great. > CONFIG_DEBUG_TEST_DRIVER_REMOVE finds lots of errors. The help text > currently undersells exactly how many errors this option will find. Add > a bit more description to indicate this option shouldn't be turned on > unless you actually want to debug driver removal. The text can be > changed later when more drivers are fixed up. Indeed, this is failing miserably for e.g. SoC clock drivers using platform_driver_probe(), which are never retried, rendering the complete system useless. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] driver core: Make Kconfig text for DEBUG_TEST_DRIVER_REMOVE stronger 2016-10-31 10:12 ` [PATCH] driver core: Make Kconfig text for DEBUG_TEST_DRIVER_REMOVE stronger Geert Uytterhoeven @ 2016-10-31 12:21 ` Greg Kroah-Hartman 2016-10-31 12:28 ` Geert Uytterhoeven 0 siblings, 1 reply; 6+ messages in thread From: Greg Kroah-Hartman @ 2016-10-31 12:21 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Laura Abbott, Rob Herring, Arnd Bergmann, linux-kernel@vger.kernel.org, linux-clk On Mon, Oct 31, 2016 at 11:12:45AM +0100, Geert Uytterhoeven wrote: > On Fri, Oct 7, 2016 at 6:09 PM, Laura Abbott <labbott@redhat.com> wrote: > > The current state of driver removal is not great. > > CONFIG_DEBUG_TEST_DRIVER_REMOVE finds lots of errors. The help text > > currently undersells exactly how many errors this option will find. Add > > a bit more description to indicate this option shouldn't be turned on > > unless you actually want to debug driver removal. The text can be > > changed later when more drivers are fixed up. > > Indeed, this is failing miserably for e.g. SoC clock drivers using > platform_driver_probe(), which are never retried, rendering the complete > system useless. Why are they never retried? ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] driver core: Make Kconfig text for DEBUG_TEST_DRIVER_REMOVE stronger 2016-10-31 12:21 ` Greg Kroah-Hartman @ 2016-10-31 12:28 ` Geert Uytterhoeven 2016-10-31 14:10 ` Rob Herring 0 siblings, 1 reply; 6+ messages in thread From: Geert Uytterhoeven @ 2016-10-31 12:28 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: Laura Abbott, Rob Herring, Arnd Bergmann, linux-kernel@vger.kernel.org, linux-clk Hi Greg, On Mon, Oct 31, 2016 at 1:21 PM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > On Mon, Oct 31, 2016 at 11:12:45AM +0100, Geert Uytterhoeven wrote: >> On Fri, Oct 7, 2016 at 6:09 PM, Laura Abbott <labbott@redhat.com> wrote: >> > The current state of driver removal is not great. >> > CONFIG_DEBUG_TEST_DRIVER_REMOVE finds lots of errors. The help text >> > currently undersells exactly how many errors this option will find. Add >> > a bit more description to indicate this option shouldn't be turned on >> > unless you actually want to debug driver removal. The text can be >> > changed later when more drivers are fixed up. >> >> Indeed, this is failing miserably for e.g. SoC clock drivers using >> platform_driver_probe(), which are never retried, rendering the complete >> system useless. > > Why are they never retried? Because platform_driver_probe() is meant for non-hotpluggable devices, and unregisters the platform driver immediately if probe fails. See also the comments for __platform_driver_probe(): * Note that this is incompatible with deferred probing. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] driver core: Make Kconfig text for DEBUG_TEST_DRIVER_REMOVE stronger 2016-10-31 12:28 ` Geert Uytterhoeven @ 2016-10-31 14:10 ` Rob Herring 2016-10-31 15:07 ` Greg Kroah-Hartman 0 siblings, 1 reply; 6+ messages in thread From: Rob Herring @ 2016-10-31 14:10 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Greg Kroah-Hartman, Laura Abbott, Arnd Bergmann, linux-kernel@vger.kernel.org, linux-clk On Mon, Oct 31, 2016 at 7:28 AM, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > Hi Greg, > > On Mon, Oct 31, 2016 at 1:21 PM, Greg Kroah-Hartman > <gregkh@linuxfoundation.org> wrote: >> On Mon, Oct 31, 2016 at 11:12:45AM +0100, Geert Uytterhoeven wrote: >>> On Fri, Oct 7, 2016 at 6:09 PM, Laura Abbott <labbott@redhat.com> wrote: >>> > The current state of driver removal is not great. >>> > CONFIG_DEBUG_TEST_DRIVER_REMOVE finds lots of errors. The help text >>> > currently undersells exactly how many errors this option will find. Add >>> > a bit more description to indicate this option shouldn't be turned on >>> > unless you actually want to debug driver removal. The text can be >>> > changed later when more drivers are fixed up. >>> >>> Indeed, this is failing miserably for e.g. SoC clock drivers using >>> platform_driver_probe(), which are never retried, rendering the complete >>> system useless. >> >> Why are they never retried? > > Because platform_driver_probe() is meant for non-hotpluggable devices, > and unregisters the platform driver immediately if probe fails. > See also the comments for __platform_driver_probe(): My patch "driver core: skip removal test for non-removable drivers" fixes this case. It seems to have dropped from Greg's queue, so I'll resend. Rob ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] driver core: Make Kconfig text for DEBUG_TEST_DRIVER_REMOVE stronger 2016-10-31 14:10 ` Rob Herring @ 2016-10-31 15:07 ` Greg Kroah-Hartman 2016-10-31 15:07 ` Greg Kroah-Hartman 0 siblings, 1 reply; 6+ messages in thread From: Greg Kroah-Hartman @ 2016-10-31 15:07 UTC (permalink / raw) To: Rob Herring Cc: Geert Uytterhoeven, Laura Abbott, Arnd Bergmann, linux-kernel@vger.kernel.org, linux-clk On Mon, Oct 31, 2016 at 09:10:57AM -0500, Rob Herring wrote: > On Mon, Oct 31, 2016 at 7:28 AM, Geert Uytterhoeven > <geert@linux-m68k.org> wrote: > > Hi Greg, > > > > On Mon, Oct 31, 2016 at 1:21 PM, Greg Kroah-Hartman > > <gregkh@linuxfoundation.org> wrote: > >> On Mon, Oct 31, 2016 at 11:12:45AM +0100, Geert Uytterhoeven wrote: > >>> On Fri, Oct 7, 2016 at 6:09 PM, Laura Abbott <labbott@redhat.com> wrote: > >>> > The current state of driver removal is not great. > >>> > CONFIG_DEBUG_TEST_DRIVER_REMOVE finds lots of errors. The help text > >>> > currently undersells exactly how many errors this option will find. Add > >>> > a bit more description to indicate this option shouldn't be turned on > >>> > unless you actually want to debug driver removal. The text can be > >>> > changed later when more drivers are fixed up. > >>> > >>> Indeed, this is failing miserably for e.g. SoC clock drivers using > >>> platform_driver_probe(), which are never retried, rendering the complete > >>> system useless. > >> > >> Why are they never retried? > > > > Because platform_driver_probe() is meant for non-hotpluggable devices, > > and unregisters the platform driver immediately if probe fails. > > See also the comments for __platform_driver_probe(): > > My patch "driver core: skip removal test for non-removable drivers" > fixes this case. It seems to have dropped from Greg's queue, so I'll > resend. Odd, I don't see that anywhere here, sorry about that... ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] driver core: Make Kconfig text for DEBUG_TEST_DRIVER_REMOVE stronger 2016-10-31 15:07 ` Greg Kroah-Hartman @ 2016-10-31 15:07 ` Greg Kroah-Hartman 0 siblings, 0 replies; 6+ messages in thread From: Greg Kroah-Hartman @ 2016-10-31 15:07 UTC (permalink / raw) To: Rob Herring Cc: Geert Uytterhoeven, Laura Abbott, Arnd Bergmann, linux-kernel@vger.kernel.org, linux-clk On Mon, Oct 31, 2016 at 09:07:24AM -0600, Greg Kroah-Hartman wrote: > On Mon, Oct 31, 2016 at 09:10:57AM -0500, Rob Herring wrote: > > On Mon, Oct 31, 2016 at 7:28 AM, Geert Uytterhoeven > > <geert@linux-m68k.org> wrote: > > > Hi Greg, > > > > > > On Mon, Oct 31, 2016 at 1:21 PM, Greg Kroah-Hartman > > > <gregkh@linuxfoundation.org> wrote: > > >> On Mon, Oct 31, 2016 at 11:12:45AM +0100, Geert Uytterhoeven wrote: > > >>> On Fri, Oct 7, 2016 at 6:09 PM, Laura Abbott <labbott@redhat.com> wrote: > > >>> > The current state of driver removal is not great. > > >>> > CONFIG_DEBUG_TEST_DRIVER_REMOVE finds lots of errors. The help text > > >>> > currently undersells exactly how many errors this option will find. Add > > >>> > a bit more description to indicate this option shouldn't be turned on > > >>> > unless you actually want to debug driver removal. The text can be > > >>> > changed later when more drivers are fixed up. > > >>> > > >>> Indeed, this is failing miserably for e.g. SoC clock drivers using > > >>> platform_driver_probe(), which are never retried, rendering the complete > > >>> system useless. > > >> > > >> Why are they never retried? > > > > > > Because platform_driver_probe() is meant for non-hotpluggable devices, > > > and unregisters the platform driver immediately if probe fails. > > > See also the comments for __platform_driver_probe(): > > > > My patch "driver core: skip removal test for non-removable drivers" > > fixes this case. It seems to have dropped from Greg's queue, so I'll > > resend. > > Odd, I don't see that anywhere here, sorry about that... Ah, found it, will queue it up now. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-10-31 15:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <120f00f2-94b6-aead-7bb4-9917bc338660@redhat.com>
[not found] ` <1475856570-10743-1-git-send-email-labbott@redhat.com>
2016-10-31 10:12 ` [PATCH] driver core: Make Kconfig text for DEBUG_TEST_DRIVER_REMOVE stronger Geert Uytterhoeven
2016-10-31 12:21 ` Greg Kroah-Hartman
2016-10-31 12:28 ` Geert Uytterhoeven
2016-10-31 14:10 ` Rob Herring
2016-10-31 15:07 ` Greg Kroah-Hartman
2016-10-31 15:07 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).