From: Stephen Boyd <sboyd@codeaurora.org>
To: Peter Chen <peter.chen@nxp.com>
Cc: shawnguo@kernel.org, mturquette@baylibre.com,
linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de,
devicetree@vger.kernel.org, robh+dt@kernel.org,
fabio.estevam@nxp.com, mark.rutland@arm.com,
linux-clk@vger.kernel.org, Bai Ping <ping.bai@nxp.com>,
Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH 3/3] clk: imx: clk-imx6ul: add clk support for imx6ull
Date: Tue, 1 Nov 2016 17:12:05 -0700 [thread overview]
Message-ID: <20161102001205.GA16026@codeaurora.org> (raw)
In-Reply-To: <1477969343-19887-4-git-send-email-peter.chen@nxp.com>
On 11/01, Peter Chen wrote:
> clks[IMX6UL_CLK_USDHC1] = imx_clk_gate2("usdhc1", "usdhc1_podf", base + 0x80, 2);
> clks[IMX6UL_CLK_USDHC2] = imx_clk_gate2("usdhc2", "usdhc2_podf", base + 0x80, 4);
> - clks[IMX6UL_CLK_SIM1] = imx_clk_gate2("sim1", "sim_sel", base + 0x80, 6);
> - clks[IMX6UL_CLK_SIM2] = imx_clk_gate2("sim2", "sim_sel", base + 0x80, 8);
> + if (clk_on_imx6ul()) {
> + clks[IMX6UL_CLK_SIM1] = imx_clk_gate2("sim1", "sim_sel", base + 0x80, 6);
> + clks[IMX6UL_CLK_SIM2] = imx_clk_gate2("sim2", "sim_sel", base + 0x80, 8);
> + }
> clks[IMX6UL_CLK_EIM] = imx_clk_gate2("eim", "eim_slow_podf", base + 0x80, 10);
> clks[IMX6UL_CLK_PWM8] = imx_clk_gate2("pwm8", "perclk", base + 0x80, 16);
> clks[IMX6UL_CLK_UART8_IPG] = imx_clk_gate2("uart8_ipg", "ipg", base + 0x80, 14);
> @@ -430,6 +478,7 @@ static void __init imx6ul_clocks_init(struct device_node *ccm_node)
> clk_set_rate(clks[IMX6UL_CLK_ENET_REF], 50000000);
> clk_set_rate(clks[IMX6UL_CLK_ENET2_REF], 50000000);
> clk_set_rate(clks[IMX6UL_CLK_CSI], 24000000);
> + clk_set_rate(clks[IMX6UL_CLK_PLL3_PFD2], 320000000);
Can you use assigned clock rates for this instead?
>
> /* keep all the clks on just for bringup */
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-11-02 0:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-01 3:02 [PATCH 0/3] imx: add imx6ull support Peter Chen
2016-11-01 3:02 ` [PATCH 1/3] ARM: imx6u: " Peter Chen
2016-11-05 8:59 ` Shawn Guo
2016-11-08 3:44 ` Peter Chen
2016-11-01 3:02 ` [PATCH 2/3] ARM: imx: mach-imx6ul: " Peter Chen
2016-11-01 10:29 ` Fabio Estevam
2016-11-01 10:44 ` Peter Chen
2016-11-01 12:23 ` Fabio Estevam
2016-11-01 3:02 ` [PATCH 3/3] clk: imx: clk-imx6ul: add clk support for imx6ull Peter Chen
2016-11-02 0:12 ` Stephen Boyd [this message]
2016-11-02 6:45 ` Peter Chen
2016-11-05 9:05 ` Shawn Guo
2016-11-08 3:44 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161102001205.GA16026@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=peng.fan@nxp.com \
--cc=peter.chen@nxp.com \
--cc=ping.bai@nxp.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).