From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: "Stéphan Rafin" <stephan@soliotek.com>
Cc: emilio@elopez.com.ar, mturquette@baylibre.com,
sboyd@codeaurora.org, wens@csie.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@googlegroups.com, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: sunxi: Fix M factor computation for APB1
Date: Fri, 4 Nov 2016 08:49:40 +0100 [thread overview]
Message-ID: <20161104074940.ak46ghzoa3o3xcie@lukather> (raw)
In-Reply-To: <1478217236-12831-1-git-send-email-stephan@soliotek.com>
[-- Attachment #1: Type: text/plain, Size: 939 bytes --]
On Fri, Nov 04, 2016 at 12:53:56AM +0100, Stéphan Rafin wrote:
> commit cfa636886033 ("clk: sunxi: factors: Consolidate get_factors
> parameters into a struct") introduced a regression for m factor
> computation in sun4i_get_apb1_factors function.
>
> The old code reassigned the "parent_rate" parameter to the targeted
> divisor value and was buggy for the returned frequency but not for the
> computed factors. Now, returned frequency is good but m factor is
> incorrectly computed (its max value 31 is always set resulting in a
> significantly slower frequency than the requested one...)
>
> This patch simply restores the original proper computation for m while
> keeping the good changes for returned rate.
>
> Signed-off-by: Stéphan Rafin <stephan@soliotek.com>
Applied (added a Fixes tag), thanks
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
prev parent reply other threads:[~2016-11-04 7:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-03 23:53 [PATCH] clk: sunxi: Fix M factor computation for APB1 Stéphan Rafin
2016-11-04 7:49 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161104074940.ak46ghzoa3o3xcie@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=emilio@elopez.com.ar \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=stephan@soliotek.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox