From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Date: Mon, 7 Nov 2016 19:41:58 +0200 From: Krzysztof Kozlowski To: Pankaj Dubey Cc: linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, krzk@kernel.org, javier@osg.samsung.com, kgene@kernel.org, thomas.ab@samsung.com, myungjoo.ham@samsung.com, Michael Turquette , Rob Herring , devicetree@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH 3/6] clk: Add driver for Maxim-8997 PMIC clocks Message-ID: <20161107174158.GB4865@kozik-lap> References: <1478513376-14307-1-git-send-email-pankaj.dubey@samsung.com> <1478513376-14307-4-git-send-email-pankaj.dubey@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: <1478513376-14307-4-git-send-email-pankaj.dubey@samsung.com> List-ID: On Mon, Nov 07, 2016 at 03:39:33PM +0530, Pankaj Dubey wrote: > The MAX8997 PMIC has 32.786kHz crystal oscillator which provides an > accurate low frequency clock for MAX8997 internal circuit as well as > external circuit. This patch adds support for these two clocks. > > CC: Michael Turquette > CC: Rob Herring > CC: devicetree@vger.kernel.org > CC: linux-clk@vger.kernel.org > Signed-off-by: Pankaj Dubey > --- > drivers/clk/Kconfig | 10 ++++ > drivers/clk/Makefile | 1 + > drivers/clk/clk-max8997.c | 76 +++++++++++++++++++++++++++++++ > include/dt-bindings/clock/maxim,max8997.h | 23 ++++++++++ You need to split the dt-bindings header into separate one so others could pull it. Please also mention the dependencies between patches in cover letter, because it does not look like it could be applied as is. Best regards, Krzysztof