From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 13 Dec 2016 09:16:37 +0000 From: Charles Keepax To: Nicholas Mc Guire CC: Michael Turquette , Mark Brown , Stephen Boyd , , , Subject: Re: [PATCH RFC] clk: wm831x: fix usleep_range with bad range Message-ID: <20161213091637.GM1867@localhost.localdomain> References: <1481528409-5182-1-git-send-email-hofrat@osadl.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" In-Reply-To: <1481528409-5182-1-git-send-email-hofrat@osadl.org> List-ID: On Mon, Dec 12, 2016 at 08:40:09AM +0100, Nicholas Mc Guire wrote: > The delay here is not in atomic context and does not seem critical with > respect to precision, but usleep_range(min,max) with min==max results in > giving the timer subsystem no room to optimize uncritical delays. Fix > this by setting the range to 2000,3000 us. > > Fixes: commit f05259a6ffa4 ("clk: wm831x: Add initial WM831x clock driver") > Signed-off-by: Nicholas Mc Guire > --- Yeah looks fine waiting longer for the FLL to lock won't cause any issues. Acked-by: Charles Keepax Thanks, Charles