[PATCHv2 0/3] arm64/clk: update Marvell Armada CP110 system controller driver

[PATCHv2 0/3] arm64/clk: update Marvell Armada CP110 system controller driver

[Thomas Petazzoni]

Hello,

This small set of commits updates the Marvell Armada CP110 system
controller driver, its Device Tree binding, and Device Tree
representation, to take into account three new things:

 - The clock driver now handles clock n°9 (GOP) as a child of clock
   n°18 (controls SD/MMC and GOP)

 - The DT representation is adjusted to name clock n°18 "sd-mmc-gop"
   instead of just "sd-mmc".

 - The clock driver now handles clock n°5 (MG) as a child of clock n°6
   (MG_CORE).

This set of commits is some preparation work to add networking support
for Marvell Armada 7K/8K.

I would expect patches 1 and 2 to be taken by the clock maintainers,
and patch 3 be taken by the Marvell EBU maintainers.

Changes since v1:

 - Addition of the handling of the MG and MG_CORE clocks (n°5 and
   n°6), also needed for the networking support on Marvell Aramda
   7K/8K.

Thanks,

Thomas

Thomas Petazzoni (3):
  dt-bindings: arm: update Armada CP110 system controller binding
  clk: mvebu: adjust clock handling for the CP110 system controller
  arm64: dts: marvell: adjust name of sd-mmc-gop clock in syscon

 .../bindings/arm/marvell/cp110-system-controller0.txt       |  6 +++---
 arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi        |  2 +-
 arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi         |  2 +-
 drivers/clk/mvebu/cp110-system-controller.c                 | 13 +++++++++++--
 4 files changed, 16 insertions(+), 7 deletions(-)

-- 
2.7.4

[PATCHv2 1/3] dt-bindings: arm: update Armada CP110 system controller binding

[Thomas Petazzoni]

It turns out that in the CP110 HW block present in Marvell Armada
7K/8K SoCs, gatable clock n°18 not only controls SD/MMC, but also the
GOP block. This commit updates the Device Tree binding for this piece
of hardware accordingly.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 .../devicetree/bindings/arm/marvell/cp110-system-controller0.txt    | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/marvell/cp110-system-controller0.txt b/Documentation/devicetree/bindings/arm/marvell/cp110-system-controller0.txt
index 30c5469..07dbb35 100644
--- a/Documentation/devicetree/bindings/arm/marvell/cp110-system-controller0.txt
+++ b/Documentation/devicetree/bindings/arm/marvell/cp110-system-controller0.txt
@@ -45,7 +45,7 @@ The following clocks are available:
    - 1 15	SATA
    - 1 16	SATA USB
    - 1 17	Main
-   - 1 18	SD/MMC
+   - 1 18	SD/MMC/GOP
    - 1 21	Slow IO (SPI, NOR, BootROM, I2C, UART)
    - 1 22	USB3H0
    - 1 23	USB3H1
@@ -65,7 +65,7 @@ Required properties:
 	"cpm-audio", "cpm-communit", "cpm-nand", "cpm-ppv2", "cpm-sdio",
 	"cpm-mg-domain", "cpm-mg-core", "cpm-xor1", "cpm-xor0", "cpm-gop-dp", "none",
 	"cpm-pcie_x10", "cpm-pcie_x11", "cpm-pcie_x4", "cpm-pcie-xor", "cpm-sata",
-	"cpm-sata-usb", "cpm-main", "cpm-sd-mmc", "none", "none", "cpm-slow-io",
+	"cpm-sata-usb", "cpm-main", "cpm-sd-mmc-gop", "none", "none", "cpm-slow-io",
 	"cpm-usb3h0", "cpm-usb3h1", "cpm-usb3dev", "cpm-eip150", "cpm-eip197";
 
 Example:
@@ -78,6 +78,6 @@ Example:
 		gate-clock-output-names = "cpm-audio", "cpm-communit", "cpm-nand", "cpm-ppv2", "cpm-sdio",
 			"cpm-mg-domain", "cpm-mg-core", "cpm-xor1", "cpm-xor0", "cpm-gop-dp", "none",
 			"cpm-pcie_x10", "cpm-pcie_x11", "cpm-pcie_x4", "cpm-pcie-xor", "cpm-sata",
-			"cpm-sata-usb", "cpm-main", "cpm-sd-mmc", "none", "none", "cpm-slow-io",
+			"cpm-sata-usb", "cpm-main", "cpm-sd-mmc-gop", "none", "none", "cpm-slow-io",
 			"cpm-usb3h0", "cpm-usb3h1", "cpm-usb3dev", "cpm-eip150", "cpm-eip197";
 	};
-- 
2.7.4

Re: [PATCHv2 1/3] dt-bindings: arm: update Armada CP110 system controller binding

[Stephen Boyd]

On 12/21, Thomas Petazzoni wrote:
> It turns out that in the CP110 HW block present in Marvell Armada
> 7K/8K SoCs, gatable clock n°18 not only controls SD/MMC, but also the
> GOP block. This commit updates the Device Tree binding for this piece
> of hardware accordingly.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---

Applied to clk-next

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: [PATCHv2 1/3] dt-bindings: arm: update Armada CP110 system controller binding

[Thomas Petazzoni]

Stephen,

On Wed, 21 Dec 2016 16:14:53 -0800, Stephen Boyd wrote:
> On 12/21, Thomas Petazzoni wrote:
> > It turns out that in the CP110 HW block present in Marvell Armada
> > 7K/8K SoCs, gatable clock n=C2=B018 not only controls SD/MMC, but also =
the
> > GOP block. This commit updates the Device Tree binding for this piece
> > of hardware accordingly.
> >=20
> > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> > --- =20
>=20
> Applied to clk-next

Even though you said you applied it, I still don't see this patch in
mainline, while PATCH 2/3 of this series is now in mainline.

Was this patch forgotten? Let me know if I should resend it, but I'm
pretty sure it still applies, since no other changes on this file have
been merged since quite a while.

Thanks,

Thomas
--=20
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Re: [PATCHv2 1/3] dt-bindings: arm: update Armada CP110 system controller binding

[Stephen Boyd]

On 03/01, Thomas Petazzoni wrote:
> Stephen,
> 
> On Wed, 21 Dec 2016 16:14:53 -0800, Stephen Boyd wrote:
> > On 12/21, Thomas Petazzoni wrote:
> > > It turns out that in the CP110 HW block present in Marvell Armada
> > > 7K/8K SoCs, gatable clock n°18 not only controls SD/MMC, but also the
> > > GOP block. This commit updates the Device Tree binding for this piece
> > > of hardware accordingly.
> > > 
> > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> > > ---  
> > 
> > Applied to clk-next
> 
> Even though you said you applied it, I still don't see this patch in
> mainline, while PATCH 2/3 of this series is now in mainline.
> 
> Was this patch forgotten? Let me know if I should resend it, but I'm
> pretty sure it still applies, since no other changes on this file have
> been merged since quite a while.
> 

No worries. I've made a note to put it into the fixes queue to
send off after rc1.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: [PATCHv2 1/3] dt-bindings: arm: update Armada CP110 system controller binding

[Thomas Petazzoni]

Hello,

On Wed, 1 Mar 2017 11:01:27 -0800, Stephen Boyd wrote:

> > Even though you said you applied it, I still don't see this patch in
> > mainline, while PATCH 2/3 of this series is now in mainline.
> > 
> > Was this patch forgotten? Let me know if I should resend it, but I'm
> > pretty sure it still applies, since no other changes on this file have
> > been merged since quite a while.
> >   
> 
> No worries. I've made a note to put it into the fixes queue to
> send off after rc1.

Great, thanks a lot. It's not a big thing, but it keeps popping up in
my list of "things accepted by the maintainer, but not yet completely
merged upstream" :-)

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[PATCHv2 2/3] clk: mvebu: adjust clock handling for the CP110 system controller

[Thomas Petazzoni]

This commit:

 - makes the GOP_DP (bit 9) gatable clock a child clock of the
   SD_MMC_GOP (bit 18) clock, as it should have been. The clock for bit
   18 was just named SD_MMC, but since it also covers the GOP block, it
   is renamed SD_MMC_GOP.

 - makes the MG (bit 5) gatable clock a child clock of the MG_CORE
   clock (bit 6)

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 drivers/clk/mvebu/cp110-system-controller.c | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/mvebu/cp110-system-controller.c b/drivers/clk/mvebu/cp110-system-controller.c
index f2303da..8038b93 100644
--- a/drivers/clk/mvebu/cp110-system-controller.c
+++ b/drivers/clk/mvebu/cp110-system-controller.c
@@ -64,8 +64,11 @@ enum {
 #define CP110_GATE_NAND			2
 #define CP110_GATE_PPV2			3
 #define CP110_GATE_SDIO			4
+#define CP110_GATE_MG			5
+#define CP110_GATE_MG_CORE		6
 #define CP110_GATE_XOR1			7
 #define CP110_GATE_XOR0			8
+#define CP110_GATE_GOP_DP		9
 #define CP110_GATE_PCIE_X1_0		11
 #define CP110_GATE_PCIE_X1_1		12
 #define CP110_GATE_PCIE_X4		13
@@ -73,7 +76,7 @@ enum {
 #define CP110_GATE_SATA			15
 #define CP110_GATE_SATA_USB		16
 #define CP110_GATE_MAIN			17
-#define CP110_GATE_SDMMC		18
+#define CP110_GATE_SDMMC_GOP		18
 #define CP110_GATE_SLOW_IO		21
 #define CP110_GATE_USB3H0		22
 #define CP110_GATE_USB3H1		23
@@ -302,6 +305,11 @@ static int cp110_syscon_clk_probe(struct platform_device *pdev)
 						      "gate-clock-output-names",
 						      CP110_GATE_MAIN, &parent);
 			break;
+		case CP110_GATE_MG:
+			of_property_read_string_index(np,
+						      "gate-clock-output-names",
+						      CP110_GATE_MG_CORE, &parent);
+			break;
 		case CP110_GATE_NAND:
 			parent = nand_name;
 			break;
@@ -309,9 +317,10 @@ static int cp110_syscon_clk_probe(struct platform_device *pdev)
 			parent = ppv2_name;
 			break;
 		case CP110_GATE_SDIO:
+		case CP110_GATE_GOP_DP:
 			of_property_read_string_index(np,
 						      "gate-clock-output-names",
-						      CP110_GATE_SDMMC, &parent);
+						      CP110_GATE_SDMMC_GOP, &parent);
 			break;
 		case CP110_GATE_XOR1:
 		case CP110_GATE_XOR0:
-- 
2.7.4

Re: [PATCHv2 2/3] clk: mvebu: adjust clock handling for the CP110 system controller

[Stephen Boyd]

On 12/21, Thomas Petazzoni wrote:
> This commit:
> 
>  - makes the GOP_DP (bit 9) gatable clock a child clock of the
>    SD_MMC_GOP (bit 18) clock, as it should have been. The clock for bit
>    18 was just named SD_MMC, but since it also covers the GOP block, it
>    is renamed SD_MMC_GOP.
> 
>  - makes the MG (bit 5) gatable clock a child clock of the MG_CORE
>    clock (bit 6)
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---

Applied to clk-next

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: [PATCHv2 2/3] clk: mvebu: adjust clock handling for the CP110 system controller

[Thomas Petazzoni]

Hello Stephen,

On Wed, 21 Dec 2016 16:14:56 -0800, Stephen Boyd wrote:
> On 12/21, Thomas Petazzoni wrote:
> > This commit:
> > 
> >  - makes the GOP_DP (bit 9) gatable clock a child clock of the
> >    SD_MMC_GOP (bit 18) clock, as it should have been. The clock for bit
> >    18 was just named SD_MMC, but since it also covers the GOP block, it
> >    is renamed SD_MMC_GOP.
> > 
> >  - makes the MG (bit 5) gatable clock a child clock of the MG_CORE
> >    clock (bit 6)
> > 
> > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> > ---  
> 
> Applied to clk-next

I don't see my patch in clk-next at
https://git.kernel.org/cgit/linux/kernel/git/clk/linux.git/log/drivers/clk/mvebu/cp110-system-controller.c?h=clk-next,
nor in linux-next. Am I missing something?

Thanks a lot,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Re: [PATCHv2 2/3] clk: mvebu: adjust clock handling for the CP110 system controller

[Stephen Boyd]

On 02/14, Thomas Petazzoni wrote:
> Hello Stephen,
> 
> On Wed, 21 Dec 2016 16:14:56 -0800, Stephen Boyd wrote:
> > On 12/21, Thomas Petazzoni wrote:
> > > This commit:
> > > 
> > >  - makes the GOP_DP (bit 9) gatable clock a child clock of the
> > >    SD_MMC_GOP (bit 18) clock, as it should have been. The clock for bit
> > >    18 was just named SD_MMC, but since it also covers the GOP block, it
> > >    is renamed SD_MMC_GOP.
> > > 
> > >  - makes the MG (bit 5) gatable clock a child clock of the MG_CORE
> > >    clock (bit 6)
> > > 
> > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> > > ---  
> > 
> > Applied to clk-next
> 
> I don't see my patch in clk-next at
> https://git.kernel.org/cgit/linux/kernel/git/clk/linux.git/log/drivers/clk/mvebu/cp110-system-controller.c?h=clk-next,
> nor in linux-next. Am I missing something?
> 

Odd. I don't know what happened. I've applied it now.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: [PATCHv2 2/3] clk: mvebu: adjust clock handling for the CP110 system controller

[Thomas Petazzoni]

Hello,

On Tue, 14 Feb 2017 10:59:12 -0800, Stephen Boyd wrote:

> > I don't see my patch in clk-next at
> > https://git.kernel.org/cgit/linux/kernel/git/clk/linux.git/log/drivers/clk/mvebu/cp110-system-controller.c?h=clk-next,
> > nor in linux-next. Am I missing something?
> 
> Odd. I don't know what happened. I've applied it now.

I think you also forgot to apply:

  [PATCHv2 1/3] dt-bindings: arm: update Armada CP110 system controller binding

from the same series. You told me "Applied to clk-next", but I don't
see it in linux-next.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[PATCHv2 3/3] arm64: dts: marvell: adjust name of sd-mmc-gop clock in syscon

[Thomas Petazzoni]

This commit adjusts the names of gatable clock #18 of the Marvell Armada
CP110 system controller. This clock not only controls SD/MMC, but also
the GOP (Group Of Ports) used for networking. So the clock is renamed to
{cpm,cps}-sd-mmc-gop instead of {cpm,cps}-sd-mmc.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi | 2 +-
 arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi
index 602e2c2..895babc 100644
--- a/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-cp110-master.dtsi
@@ -74,7 +74,7 @@
 					"cpm-gop-dp", "none", "cpm-pcie_x10",
 					"cpm-pcie_x11", "cpm-pcie_x4", "cpm-pcie-xor",
 					"cpm-sata", "cpm-sata-usb", "cpm-main",
-					"cpm-sd-mmc", "none", "none",
+					"cpm-sd-mmc-gop", "none", "none",
 					"cpm-slow-io", "cpm-usb3h0", "cpm-usb3h1",
 					"cpm-usb3dev", "cpm-eip150", "cpm-eip197";
 			};
diff --git a/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi
index 6bf9e24..db99646 100644
--- a/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi
@@ -74,7 +74,7 @@
 					"cps-gop-dp", "none", "cps-pcie_x10",
 					"cps-pcie_x11", "cps-pcie_x4", "cps-pcie-xor",
 					"cps-sata", "cps-sata-usb", "cps-main",
-					"cps-sd-mmc", "none", "none",
+					"cps-sd-mmc-gop", "none", "none",
 					"cps-slow-io", "cps-usb3h0", "cps-usb3h1",
 					"cps-usb3dev", "cps-eip150", "cps-eip197";
 			};
-- 
2.7.4

Re: [PATCHv2 3/3] arm64: dts: marvell: adjust name of sd-mmc-gop clock in syscon

[Thomas Petazzoni]

Hello,

On Wed, 21 Dec 2016 11:26:57 +0100, Thomas Petazzoni wrote:
> This commit adjusts the names of gatable clock #18 of the Marvell Armada
> CP110 system controller. This clock not only controls SD/MMC, but also
> the GOP (Group Of Ports) used for networking. So the clock is renamed to
> {cpm,cps}-sd-mmc-gop instead of {cpm,cps}-sd-mmc.
>=20
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Gr=C3=A9gory, since patches 1/3 and 2/3 of this series have been applied,
could you take this PATCH 3/3 ?

Thanks!

Thomas
--=20
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Re: [PATCHv2 3/3] arm64: dts: marvell: adjust name of sd-mmc-gop clock in syscon

[Gregory CLEMENT]

Hi Thomas,
=20
 On mar., janv. 31 2017, Thomas Petazzoni <thomas.petazzoni@free-electrons.=
com> wrote:

> Hello,
>
> On Wed, 21 Dec 2016 11:26:57 +0100, Thomas Petazzoni wrote:
>> This commit adjusts the names of gatable clock #18 of the Marvell Armada
>> CP110 system controller. This clock not only controls SD/MMC, but also
>> the GOP (Group Of Ports) used for networking. So the clock is renamed to
>> {cpm,cps}-sd-mmc-gop instead of {cpm,cps}-sd-mmc.
>>=20
>> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>
> Gr=C3=A9gory, since patches 1/3 and 2/3 of this series have been applied,
> could you take this PATCH 3/3 ?

I completely missed this patch!

Now, applied on mvebu/dt64

Thanks,

Gregory



>
> Thanks!
>
> Thomas
> --=20
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com

--=20
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com