Re: [PATCH 6/15] dt-bindings: display: sun4i: Add HDMI display bindings

Maxime Ripard
2017-04-03T20:59:53Z

[-- Attachment #1: Type: text/plain, Size: 1491 bytes --]

Hi Rob,

On Wed, Mar 15, 2017 at 12:26:22PM -0500, Rob Herring wrote:
> > +HDMI Encoder
> > +------------
> > +
> > +The HDMI Encoder supports the HDMI video and audio outputs, and does
> > +CEC. It is one end of the pipeline.
> > +
> > +Required properties:
> > + - compatible: value must be one of:
> > + * allwinner,sun5i-a10s-hdmi
> > + - reg: base address and size of memory-mapped region
> > + - clocks: phandles to the clocks feeding the HDMI encoder
> > + * ahb: the HDMI interface clock
> > + * mod: the HDMI module clock
> > + * pll-0: the first video PLL
> > + * pll-1: the second video PLL
> > + - clock-names: the clock names mentioned above
> > +
> > + - ports: A ports node with endpoint definitions as defined in
> > + Documentation/devicetree/bindings/media/video-interfaces.txt. The
> > + first port should be the input endpoint.
>
> You need an output port to an HDMI connector node and an audio port.

I started to look at the audio, and I can't find a use for an audio
port in the OF graph. As far as I understand, we will be using the
hdmi-codec, that still requires an ASoC card to create the link
between our i2s controller and the HDMI controller.

This work perfectly for us, but as far as I know, the simple-card
stuff only requires a phandle, and not an OF graph endpoint, right?

Thanks!
Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]