From: Leo Yan <leo.yan@linaro.org>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Suzuki K Poulose <Suzuki.Poulose@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Wei Xu <xuwei5@hisilicon.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
John Stultz <john.stultz@linaro.org>,
Guodong Xu <guodong.xu@linaro.org>,
Haojian Zhuang <haojian.zhuang@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
linux-clk@vger.kernel.org, Mike Leach <mike.leach@linaro.org>,
Sudeep Holla <Sudeep.Holla@arm.com>
Subject: Re: [v3 3/5] coresight: add support for debug module
Date: Sat, 18 Mar 2017 00:28:36 +0800 [thread overview]
Message-ID: <20170317162836.GD2020@leoy-linaro> (raw)
In-Reply-To: <20170317155007.GA20435@linaro.org>
On Fri, Mar 17, 2017 at 09:50:07AM -0600, Mathieu Poirier wrote:
[...]
> If we don't check for "nohlt" some platform may freeze, others may work. If we
> mandate that "nohlt" be present on the kernel cmd line it works in all cases.
> As such mandating that "nohlt" be present is a better way to go.
Sure, so I will add below checking code in the probe function, please
let me know if you have alter better way to implement this:
+ if (IS_ENABLED(CONFIG_CPU_IDLE) &&
+ !strstr(boot_command_line, "nohlt")) {
+ dev_err(dev, "May not be accessible in CPU power domain.\n");
+ return -EPERM;
+ }
Thanks,
Leo Yan
next prev parent reply other threads:[~2017-03-17 16:28 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-03 6:00 [PATCH v3 0/5] coresight: enable debug module Leo Yan
2017-03-03 6:00 ` [PATCH v3 1/5] coresight: bindings for " Leo Yan
2017-03-03 6:00 ` [PATCH v3 2/5] coresight: refactor with function of_coresight_get_cpu Leo Yan
2017-03-03 6:00 ` [PATCH v3 3/5] coresight: add support for debug module Leo Yan
[not found] ` <011fdac0-59bf-b539-2de3-0b59a41bc922@arm.com>
2017-03-09 17:59 ` [v3 " Leo Yan
2017-03-13 16:29 ` Mathieu Poirier
[not found] ` <3f27efee-3b63-81fd-eb96-73fd7e6f5e92@arm.com>
2017-03-13 8:12 ` Leo Yan
2017-03-13 16:56 ` Mathieu Poirier
2017-03-15 16:44 ` Suzuki K Poulose
2017-03-15 20:41 ` Mathieu Poirier
2017-03-17 10:13 ` Leo Yan
2017-03-17 15:50 ` Mathieu Poirier
2017-03-17 16:28 ` Leo Yan [this message]
2017-03-17 16:47 ` Suzuki K Poulose
2017-03-20 12:30 ` Leo Yan
2017-03-20 16:40 ` Mathieu Poirier
2017-03-21 2:59 ` Leo Yan
2017-03-21 10:16 ` Suzuki K Poulose
2017-03-21 11:47 ` Leo Yan
2017-03-21 15:15 ` Mathieu Poirier
2017-03-21 15:39 ` [PATCH v3 " Sudeep Holla
2017-03-22 12:54 ` Mike Leach
2017-03-22 14:07 ` Sudeep Holla
2017-03-22 15:45 ` Mike Leach
2017-03-22 16:17 ` Sudeep Holla
2017-03-22 17:09 ` Suzuki K Poulose
2017-03-22 17:25 ` Sudeep Holla
2017-03-23 5:43 ` Leo Yan
2017-03-23 12:27 ` Mike Leach
2017-03-22 16:01 ` Leo Yan
2017-03-22 16:53 ` Sudeep Holla
2017-03-03 6:00 ` [PATCH v3 4/5] clk: hi6220: add debug APB clock Leo Yan
2017-03-03 23:58 ` Stephen Boyd
2017-03-17 15:22 ` Leo Yan
2017-03-03 6:00 ` [PATCH v3 5/5] arm64: dts: hi6220: register debug module Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170317162836.GD2020@leoy-linaro \
--to=leo.yan@linaro.org \
--cc=Sudeep.Holla@arm.com \
--cc=Suzuki.Poulose@arm.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=guodong.xu@linaro.org \
--cc=haojian.zhuang@linaro.org \
--cc=john.stultz@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=will.deacon@arm.com \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).